ARROW-2537: [Ruby] Import #1990

kou · 2018-05-03T14:04:57Z

Imported from:

pitrou · 2018-05-03T14:43:19Z

ci/travis_detect_changes.py

-        elif p in ('c_glib', 'integration', 'python', 'site', 'rust'):
+        elif p in ('c_glib'):
+            affected[p] = True
+            affected['ruby'] = True


The Ruby wrapper binds to the C/Glib binaries?

Yes.
It uses Apache Arrow C++ through Apache Arrow GLib.

wesm · 2018-05-03T23:45:01Z

@kou, this is great, thank you! Since this is a large code import, we will want to go through the IP clearance process like with Go recently http://incubator.apache.org/ip-clearance/. This should not be too painful but will require a vote on the mailing list and then a lazy consensus clearance vote on general@incubator

kou · 2018-05-04T21:36:46Z

@wesm OK. I'll read the document.

kou · 2018-05-10T22:00:16Z

@wesm I read the document. I think that I don't have "incubator karma". Can you help me to process this?

IP Clearance processing must be executed either by an Officer or a Member of the ASF. If you are not an Officer or a Member, please contact your project chair who will find an appropriate volunteer. Incubator karma is also required. Please request karma from the incubator pmc if you do not have it.

I filled some fields:

Title:

Arrow Ruby Library Intellectual Property (IP) Clearance Status

Description:

The Arrow Ruby Library is a Ruby language bindings of the Apache Arrow columnar format

Project info:

he Apache Arrow PMC will be responsible for the code.

It will be integrated into the Apache Arrow project, into a new Ruby area of the main Arrow source tree and build system.

The following people will be managing this contribution:

TBD
...

Completed tasks are shown by the completion date (YYYY-MM-dd).

Identify the codebase:

Origin: https://github.com/red-data-tools/red-arrow as at commit ID abb0d3c0349c94189a700c25ab7ca97b17b09a6f and https://github.com/red-data-tools/red-arrow-gpu as at commit ID 29025cfdc92135fd81b42fbdc29497466a7454aa.
Submitted to Apache Arrow as GitHub pull request ARROW-2537: [Ruby] Import #1990

Copyright:

Identify name recorded for software grant: Ruby Bindings of Apache Arrow

Verify distribution rights:

Corporations and individuals holding existing distribution rights:

Kouhei Sutou

DISCUSS: red-data-tools/red-arrow@701386c is only a commit made by me. It just fix a URL. Is there a copyright of mikisou? If there is a copyright of him, I'll contact to him.

Generally, the result of checking off these items will be a Software Grant, CLA, and Corporate CLA for ASF licensed code, which must have no dependencies upon items whose licenses that are incompatible with the Apache License.

Organizational acceptance of responsibility for the project:

Related votes:

TBD

wesm · 2018-05-11T22:44:12Z

hi @kou -- yes, I will help you with the IP clearance. I'm an ASF Member now so I believe I have enough karma to make changes to the IP clearance files.

First, we need to have a PMC vote to accept the Ruby bindings. I'm going to start this now on the mailing list. We can get the IP clearance page set up while that is running, so we can have the Incubator clearance vote next week and then merge the PR.

Sorry for the delay; I have been traveling the last week and not available much on e-mail or GitHub

kou · 2018-05-12T06:56:33Z

Thanks! I understand the schedule.

Sorry for the delay; I have been traveling the last week and not available much on e-mail or GitHub

No problem. Thanks for your help.

wesm · 2018-05-24T22:48:33Z

The IP clearance vote has passed. I'm going to rebase this and review, and merge on a green build if there are no problems

codecov-io · 2018-05-24T23:29:39Z

Codecov Report

Merging #1990 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1990   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files         242      242           
  Lines       41103    41103           
=======================================
  Hits        35487    35487           
  Misses       5616     5616

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c5e95a...cb41c7a. Read the comment docs.

wesm

Some minor comments from my read through. Merging this PR. Thanks @kou!

wesm · 2018-05-24T22:52:13Z

ruby/red-arrow-gpu/LICENSE.txt

@@ -0,0 +1,585 @@
+


Does the Apache license need to be reproduced here?

Oh! We should remove it and ruby/red-arrow/LICENSE.txt because we don't have additional license information for Apache Arrow Ruby.

wesm · 2018-05-24T22:54:00Z

ruby/red-arrow-gpu/README.md

+
+## Install
+
+Install Apache Arrow GPU GLib before install Red Arrow GPU. Use [packages.red-data-tools.org](https://github.com/red-data-tools/packages.red-data-tools.org) for installing Apache Arrow GPU GLib.


It should be noted here that these binaries are not official; I hope we are able to produce official GPU-enabled binaries as part of release votes in the future

I agree. I'll put the same note in Apache Arrow GLib.

wesm · 2018-05-24T22:55:41Z

ruby/red-arrow-gpu/lib/arrow-gpu/cuda-device-manager.rb

+  class CUDADeviceManager
+    # Experimental.
+    #
+    # Can we think device manager is a container of contexts?


Yes, most likely -- it would be useful to have some design review of the interface between the CUDA driver API and Apache Arrow. What I did was experimental to help get things started

wesm · 2018-05-24T23:07:52Z

ruby/red-arrow/README.md

+
+## Install
+
+Install Apache Arrow GLib before install Red Arrow. Use [packages.red-data-tools.org](https://github.com/red-data-tools/packages.red-data-tools.org) for installing Apache Arrow GLib.


Similar comment as above

wesm · 2018-05-24T23:51:09Z

ruby/red-arrow/lib/arrow/group.rb

+module Arrow
+  # Experimental
+  #
+  # TODO: Almost codes should be implemented in Apache Arrow C++.


Definitely intend to build this functionality in Arrow C++ eventually

wesm · 2018-05-25T00:00:43Z

ruby/red-arrow/lib/arrow/slicer.rb

+module Arrow
+  # Experimental
+  #
+  # TODO: Almost codes should be implemented in Apache Arrow C++.


wesm · 2018-05-25T00:02:30Z

ruby/red-arrow/lib/arrow/table-formatter.rb

+# under the License.
+
+module Arrow
+  # TODO: Almost codes should be implemented in Apache Arrow C++.


wesm · 2018-05-25T01:12:35Z

+1

kou · 2018-05-25T01:25:42Z

Thanks!!!
I'll send some follow-up pull requests to resolve your comments.

kou mentioned this pull request May 3, 2018

Interest in donating to Apache Arrow? red-data-tools/red-arrow#7

Closed

pitrou reviewed May 3, 2018

View reviewed changes

kou force-pushed the ruby-import branch from 3cc81cf to a758ec1 Compare May 4, 2018 21:31

kou force-pushed the ruby-import branch from a758ec1 to d50c854 Compare May 10, 2018 21:48

[Ruby] Import

cb41c7a

wesm force-pushed the ruby-import branch from d50c854 to cb41c7a Compare May 24, 2018 22:49

wesm approved these changes May 25, 2018

View reviewed changes

wesm closed this in 338e597 May 25, 2018

kou deleted the ruby-import branch May 25, 2018 01:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARROW-2537: [Ruby] Import #1990

ARROW-2537: [Ruby] Import #1990

kou commented May 3, 2018

pitrou May 3, 2018

kou May 4, 2018

wesm commented May 3, 2018

kou commented May 4, 2018

kou commented May 10, 2018

wesm commented May 11, 2018

kou commented May 12, 2018

wesm commented May 24, 2018

codecov-io commented May 24, 2018

wesm left a comment

wesm May 24, 2018

kou May 25, 2018

wesm May 24, 2018

kou May 25, 2018

wesm May 24, 2018

kou May 25, 2018

wesm May 24, 2018

wesm May 24, 2018

wesm May 25, 2018

wesm May 25, 2018

wesm commented May 25, 2018

kou commented May 25, 2018


		## Install

		Install Apache Arrow GPU GLib before install Red Arrow GPU. Use [packages.red-data-tools.org](https://github.com/red-data-tools/packages.red-data-tools.org) for installing Apache Arrow GPU GLib.


		## Install

		Install Apache Arrow GLib before install Red Arrow. Use [packages.red-data-tools.org](https://github.com/red-data-tools/packages.red-data-tools.org) for installing Apache Arrow GLib.

ARROW-2537: [Ruby] Import #1990

ARROW-2537: [Ruby] Import #1990

Conversation

kou commented May 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wesm commented May 3, 2018

kou commented May 4, 2018

kou commented May 10, 2018

wesm commented May 11, 2018

kou commented May 12, 2018

wesm commented May 24, 2018

codecov-io commented May 24, 2018

Codecov Report

wesm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wesm commented May 25, 2018

kou commented May 25, 2018