ARROW-2569: [C++] Improve thread pool size heuristic #2026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
force-pushed
the
ARROW-2569-thread-pool-heuristic
branch
from
d12886c
to
694d871
Compare
The heuristic goes this way: - if the OMP_NUM_THREADS environment variable exists, it defines the baseline number of available threads - otherwise, the baseline is the value returned by std::thread::harware_concurrency() - the OMP_THREAD_LIMIT environment variable, if it exists, defined the upper bound for the final value, i.e. we return min(baseline, limit), otherwise we just return the baseline. This is the heuristic used by other packages such as the GNU "nproc" utility.
pitrou
force-pushed
the
ARROW-2569-thread-pool-heuristic
branch
from
694d871
to
2dd0d12
Compare
Codecov Report
@@ Coverage Diff @@
## master #2026 +/- ##
==========================================
+ Coverage 87.41% 87.47% +0.06%
==========================================
Files 189 178 -11
Lines 29256 28584 -672
==========================================
- Hits 25573 25003 -570
+ Misses 3683 3581 -102
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heuristic goes this way:
number of available threads
for the final value, i.e. we return min(baseline, limit), otherwise we just
return the baseline.
This is the heuristic used by other packages such as the GNU "nproc" utility.