ARROW-3194: [JAVA] Use the split length for setting value count of target vector #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
changed the title
|
@laurentgo or @jacques-n can you review? |
|
Ping, @siddharthteotia do you want to get this into the 0.11 release? |
jacques-n
reviewed
Oct 1, 2018
| if (this.valueCount > 0) { | ||
| target.setValueCount(this.valueCount); | ||
| } | ||
| target.setValueCount(length); |
There was a problem hiding this comment.
Don't we still need the if the condition when the length is zero?
Author: Kouhei Sutou <kou@clear-code.com> Closes apache#2701 from kou/add-workaround-missing-gemfile and squashes the following commits: fc80d6e <Kouhei Sutou> Add workaround to verify 0.11.0
It's helpful to setup test environment. Author: Kouhei Sutou <kou@clear-code.com> Closes apache#2702 from kou/c-glib-add-missing-gemfile-to-archive and squashes the following commits: 5c97dad <Kouhei Sutou> Include Gemfile to archive
Author: Kouhei Sutou <kou@clear-code.com> Closes apache#2703 from kou/expand-variables-in-commit-message and squashes the following commits: da4f3bc <Kouhei Sutou> Expand variables in commit message
Author: Pindikura Ravindra <ravindra@dremio.com> Closes apache#2695 from pravindra/re2 and squashes the following commits: 4408b85 <Pindikura Ravindra> ARROW-3331: Add re2 to toolchain
siddharthteotia
force-pushed
the
ARROW-3194
branch
from
6ef7ee8
to
c8402d7
Compare
|
Addressed review comment. |
|
Looks good. +1 |
|
Resolved in 074e2c2. I'm not sure why this was never merged before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use the split length as the value count of the target vector. We are incorrectly using the value count of the current vector for the target vector