ARROW-3518: Detect HOMEBREW_PREFIX automatically #2761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be detected by executing `brew --prefix` if available.
mrkn
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2761 +/- ##
==========================================
+ Coverage 87.65% 88.58% +0.93%
==========================================
Files 403 342 -61
Lines 61483 57692 -3791
==========================================
- Hits 53891 51107 -2784
+ Misses 7520 6585 -935
+ Partials 72 0 -72Continue to review full report at Codecov.
|
wesm
approved these changes
Oct 15, 2018
| ) | ||
| else() | ||
| set(HOMEBREW_PREFIX "/usr/local") | ||
| endif() |
There was a problem hiding this comment.
I don't think clang-format-6 is available in Homebrew unfortunately
There was a problem hiding this comment.
I confirmed that llvm@6 has clang-format-6.0.1 👍
There was a problem hiding this comment.
Ah that's great. Let's definitely not encourage anyone to use the clang-format recipe then =) https://github.com/Homebrew/homebrew-core/blob/master/Formula/clang-format.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be detected by executing
brew --prefixif available.