-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-3441: [Gandiva] Use common unit test creation facilities, do not produce multiple executables for the same unit tests #3091
Conversation
…d gandiva custom target Change-Id: I89d02be0a5dae4c9469de957a1374635d08d03e5
Sample run:
|
I'm going to add the precompiled tests to the target, too, just a few minutes |
Change-Id: I4a8446528b516dd78123d167444b061ff37db613
Change-Id: I05c66a97966b3eeffb71f8da1d50813446e7fcdb
Codecov Report
@@ Coverage Diff @@
## master #3091 +/- ##
==========================================
+ Coverage 87.12% 88.15% +1.03%
==========================================
Files 492 434 -58
Lines 69104 65339 -3765
==========================================
- Hits 60204 57601 -2603
+ Misses 8801 7738 -1063
+ Partials 99 0 -99 Continue to review full report at Codecov.
|
lgtm. Thanks for fixing this ! |
This also adds a "gandiva" CMake target so you can run
ninja gandiva
. Additionally, all unit tests now have agandiva-
prefix.