Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4396: [JS] Update Typedoc for TypeScript 3.2 #3506

Closed
wants to merge 3 commits into from

Conversation

trxcllnt
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #3506 into master will decrease coverage by 10.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3506      +/-   ##
==========================================
- Coverage   80.67%   69.97%   -10.7%     
==========================================
  Files         129      376     +247     
  Lines        8967    51629   +42662     
  Branches     1069     1069              
==========================================
+ Hits         7234    36128   +28894     
- Misses       1618    15495   +13877     
+ Partials      115        6     -109
Impacted Files Coverage Δ
js/src/ipc/node/iterable.ts 100% <ø> (ø) ⬆️
js/src/ipc/node/writer.ts 100% <ø> (ø) ⬆️
js/src/ipc/metadata/message.ts 91.4% <ø> (ø) ⬆️
js/src/visitor/vectorctor.ts 89.06% <ø> (ø) ⬆️
js/src/util/utf8.ts 77.77% <ø> (ø) ⬆️
js/src/visitor/toarray.ts 98.3% <ø> (ø) ⬆️
js/src/visitor/indexof.ts 97.26% <ø> (ø) ⬆️
js/src/visitor/set.ts 100% <ø> (ø) ⬆️
js/src/Arrow.ts 100% <ø> (ø) ⬆️
js/src/visitor/typeassembler.ts 99.04% <ø> (ø) ⬆️
... and 369 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74fb9da...758b4bf. Read the comment docs.

@wesm
Copy link
Member

wesm commented Jan 29, 2019

There are multiple JS patches open...what's going to happen when the package.lock files conflict?

@trxcllnt
Copy link
Contributor Author

Usually they'll merge cleanly, or we can delete and regenerate them (via rm package-lock.json && npm install --package-lock) as part of resolving merge conflicts.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Will merge this and find out what happens...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants