Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35179: [C++] Set missing IMPORTED_CONFIGURATIONS property for Arrow::bundled_dependencies #35196

Merged
merged 3 commits into from
Apr 18, 2023
Merged

GH-35179: [C++] Set missing IMPORTED_CONFIGURATIONS property for Arrow::bundled_dependencies #35196

merged 3 commits into from
Apr 18, 2023

Conversation

assignUser
Copy link
Member

@assignUser assignUser commented Apr 17, 2023 •
edited by kou
Loading

What changes are included in this PR?

We need to set the IMPORTED_CONFIGURATIONS property to use IMPORTED_LOCATION_<CONFIGURATION>.

Are these changes tested?

Crossbow

@assignUser
Copy link
Member Author

assignUser commented Apr 17, 2023 •
edited
Loading

@github-actions crossbow submit -g cpp

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35179 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

Revision: 9451981

Submitted crossbow builds: ursacomputing/crossbow @ actions-7913af8c17

Task Status
test-alpine-linux-cpp Github Actions
test-build-cpp-fuzz Github Actions
test-conda-cpp Github Actions
test-conda-cpp-valgrind Azure
test-cuda-cpp Github Actions
test-debian-10-cpp-amd64 Github Actions
test-debian-10-cpp-i386 Github Actions
test-debian-11-cpp-amd64 Github Actions
test-debian-11-cpp-i386 Github Actions
test-fedora-35-cpp Github Actions
test-ubuntu-20.04-cpp Github Actions
test-ubuntu-20.04-cpp-20 Github Actions
test-ubuntu-20.04-cpp-bundled Github Actions
test-ubuntu-20.04-cpp-minimal-with-formats Github Actions
test-ubuntu-20.04-cpp-thread-sanitizer Github Actions
test-ubuntu-22.04-cpp Github Actions

@assignUser
Copy link
Member Author

@github-actions crossbow submit example-cpp-minimal-build-*

@github-actions
Copy link

Revision: 9451981

Submitted crossbow builds: ursacomputing/crossbow @ actions-d0a7badb73

Task Status
example-cpp-minimal-build-static Github Actions
example-cpp-minimal-build-static-system-dependency Github Actions

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Apr 17, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 17, 2023
@assignUser
Copy link
Member Author

@github-actions crossbow submit example-cpp-minimal-build-*

@github-actions
Copy link

Revision: c0facaf

Submitted crossbow builds: ursacomputing/crossbow @ actions-5b32bd7f02

Task Status
example-cpp-minimal-build-static Github Actions
example-cpp-minimal-build-static-system-dependency Github Actions

@assignUser assignUser marked this pull request as ready for review April 17, 2023 23:00
@assignUser assignUser requested a review from kou April 17, 2023 23:00
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Apr 18, 2023
@assignUser
Revert "fix property"
3c7c7e6 
This reverts commit 9451981.
@assignUser
Copy link
Member Author

@github-actions crossbow submit example-cpp-minimal-build-*

@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 18, 2023
@github-actions
Copy link

Revision: 3c7c7e6

Submitted crossbow builds: ursacomputing/crossbow @ actions-78b8068107

Task Status
example-cpp-minimal-build-static Github Actions
example-cpp-minimal-build-static-system-dependency Github Actions

kou
kou approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit e971cf9 into apache:main Apr 18, 2023
@kou
Copy link
Member

kou commented Apr 18, 2023

Ah, I should have updated the PR title and description before I merge this...

@github-actions github-actions bot removed the awaiting change review Awaiting change review label Apr 18, 2023
@github-actions github-actions bot added the awaiting merge Awaiting merge label Apr 18, 2023
@kou kou changed the title GH-35179: [C++] Fix IMPORTED_LOCATION property for Arrow::bundled_dependencies GH-35179: [C++] Set missing IMPORTED_CONFIGURATIONS property for Arrow::bundled_dependencies Apr 18, 2023
@assignUser assignUser deleted the fix-arrow-config branch April 18, 2023 23:56
@ursabot
Copy link

ursabot commented Apr 21, 2023

Benchmark runs are scheduled for baseline = 72d57ac and contender = e971cf9. e971cf9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️6.89% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.36% ⬆️0.06%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] e971cf93 ec2-t3-xlarge-us-east-2
[Failed] e971cf93 test-mac-arm
[Finished] e971cf93 ursa-i9-9960x
[Finished] e971cf93 ursa-thinkcentre-m75q
[Finished] 72d57ac4 ec2-t3-xlarge-us-east-2
[Failed] 72d57ac4 test-mac-arm
[Finished] 72d57ac4 ursa-i9-9960x
[Finished] 72d57ac4 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Apr 21, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@assignUser @liujiacheng777
apacheGH-35179: [C++] Fix IMPORTED_LOCATION property for Arrow::bundl…
93da77a 
…ed_dependencies (apache#35196)

### What changes are included in this PR?

The previous change used the `LOCATION_<CONFIGURATION>` property which is not set by default.

### Are these changes tested?

Crossbow
* Closes: apache#35179

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@assignUser @ArgusLi
apacheGH-35179: [C++] Fix IMPORTED_LOCATION property for Arrow::bundl…
d042d08 
…ed_dependencies (apache#35196)

### What changes are included in this PR?

The previous change used the `LOCATION_<CONFIGURATION>` property which is not set by default.

### Are these changes tested?

Crossbow
* Closes: apache#35179

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@assignUser @rtpsw
apacheGH-35179: [C++] Fix IMPORTED_LOCATION property for Arrow::bundl…
d215be6 
…ed_dependencies (apache#35196)

### What changes are included in this PR?

The previous change used the `LOCATION_<CONFIGURATION>` property which is not set by default.

### Are these changes tested?

Crossbow
* Closes: apache#35179

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI][C++] Minimal examples fail to compile due to missing configuration for arrow_bundled_dependencies
3 participants
@assignUser @kou @ursabot