Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][C++] Minimal examples fail to compile due to missing configuration for arrow_bundled_dependencies #35179

Closed
raulcd opened this issue Apr 17, 2023 · 4 comments · Fixed by #35196

Comments

@raulcd
Copy link
Member

raulcd commented Apr 17, 2023

Describe the bug, including details regarding any error messages, version, and platform.

The following jobs have been failing:
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
since b63463c was merged.

I have reproduced locally with:

$ cd arrow/cpp/examples/minimal_build
$ docker-compose run --rm static

I've checked the docker container and the built CMake seems to suggest arrow_bundled_dependencies is not found correctly:

root@70c12a6c178d:/build/example# vim CMakeFiles/arrow-example.dir/build.make 
...
# External object files for target arrow-example
arrow__example_EXTERNAL_OBJECTS =

arrow-example: CMakeFiles/arrow-example.dir/example.cc.o
arrow-example: CMakeFiles/arrow-example.dir/build.make
arrow-example: /usr/local/lib/libarrow.a
arrow-example: Arrow::arrow_bundled_dependencies-NOTFOUND
arrow-example: CMakeFiles/arrow-example.dir/link.txt

Component(s)

C++, Continuous Integration

@raulcd
Copy link
Member Author

raulcd commented Apr 17, 2023

I've validated that reverting the change for ArrowConfig.cmake.in fix the issue.

@assignUser assignUser added the Priority: Blocker Marks a blocker for the release label Apr 17, 2023
@assignUser assignUser added this to the 12.0.0 milestone Apr 17, 2023
@assignUser assignUser removed the Priority: Blocker Marks a blocker for the release label Apr 17, 2023
@assignUser assignUser removed this from the 12.0.0 milestone Apr 17, 2023
@assignUser
Copy link
Member

The problem is that the changes from #35109 expect LOCATION_<CONFIGURATION> to be set, which is not the case by default. This leads to empty vars and wrong locations.

This issue should have been found pre-merge by running crossbow jobs.
cc @kou

-- Arrow version: 12.0.0
-- Found the Arrow shared library: 
-- Found the Arrow import library: 
-- Found the Arrow static library: /usr/local/lib/libarrow.a
CMake Error at CMakeLists.txt:28 (message):
  LOCATION_RELEASE: lib dir: /usr/local/lib

@kou
Copy link
Member

kou commented Apr 17, 2023

Oh, sorry...

@assignUser
Copy link
Member

assignUser commented Apr 17, 2023

Seems to happen frequently as there is a warning specifically for this since 3.19 :D (which pop up when building with 3.19+)
https://cmake.org/cmake/help/latest/policy/CMP0111.html

kou pushed a commit that referenced this issue Apr 18, 2023
…endencies (#35196)

### What changes are included in this PR?

The previous change used the `LOCATION_<CONFIGURATION>` property which is not set by default.

### Are these changes tested?

Crossbow
* Closes: #35179

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou modified the milestones: 12.0.0, 13.0.0 Apr 18, 2023
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this issue May 11, 2023
…ed_dependencies (apache#35196)

### What changes are included in this PR?

The previous change used the `LOCATION_<CONFIGURATION>` property which is not set by default.

### Are these changes tested?

Crossbow
* Closes: apache#35179

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this issue May 15, 2023
…ed_dependencies (apache#35196)

### What changes are included in this PR?

The previous change used the `LOCATION_<CONFIGURATION>` property which is not set by default.

### Are these changes tested?

Crossbow
* Closes: apache#35179

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this issue May 16, 2023
…ed_dependencies (apache#35196)

### What changes are included in this PR?

The previous change used the `LOCATION_<CONFIGURATION>` property which is not set by default.

### Are these changes tested?

Crossbow
* Closes: apache#35179

Authored-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment