Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35279: [C++][Parquet] Tools: enhancement Parquet print stats #35262

Merged
merged 1 commit into from
Apr 21, 2023
Merged

GH-35279: [C++][Parquet] Tools: enhancement Parquet print stats #35262

merged 1 commit into from
Apr 21, 2023

Conversation

mapleFU
Copy link
Member

@mapleFU mapleFU commented Apr 21, 2023 •
edited by github-actions bot

Rationale for this change

Enhancement printing value for parquet stats

What changes are included in this PR?

  1. Make DebugPrintStats for RecordReader better
  2. Make Stats printer better

Are these changes tested?

No

Are there any user-facing changes?

No

@mapleFU mapleFU requested a review from wjones127 as a code owner April 21, 2023 06:40
@mapleFU
Copy link
Member Author

mapleFU commented Apr 21, 2023

Create an issue for ci failed: #35266

wjones127
wjones127 approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, although (while it is small) this isn't quite a MINOR PR. Could you open an issue and link that before we merge?

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 21, 2023
@mapleFU mapleFU changed the title MINOR: [C++][Parquet] Tools: enhancement Parquet print stats GH-35279: [C++][Parquet] Tools: enhancement Parquet print stats Apr 21, 2023
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35279 has been automatically assigned in GitHub to PR creator.

@mapleFU
Copy link
Member Author

mapleFU commented Apr 21, 2023

Done. By the way, how can patch be a minor change?

@wjones127
Copy link
Member

Done. By the way, how can patch be a minor change?

Basically minor changes usually just fix spelling or small issues in documentation or comments. Anything that affects actual logic isn't considered minor. See: https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes

@wjones127 wjones127 merged commit a4b2408 into apache:main Apr 21, 2023
31 of 33 checks passed
@mapleFU mapleFU deleted the parquet/print-stats-enhancement branch April 21, 2023 22:46
@mapleFU
Copy link
Member Author

mapleFU commented Apr 21, 2023

Get it, will attention that next time :)

@ursabot
Copy link

ursabot commented Apr 23, 2023

Benchmark runs are scheduled for baseline = c48916a and contender = a4b2408. a4b2408 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️1.02% ⬆️0.26%] ursa-i9-9960x
[Finished ⬇️0.42% ⬆️0.12%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] a4b2408e ec2-t3-xlarge-us-east-2
[Failed] a4b2408e test-mac-arm
[Finished] a4b2408e ursa-i9-9960x
[Finished] a4b2408e ursa-thinkcentre-m75q
[Finished] c48916a5 ec2-t3-xlarge-us-east-2
[Failed] c48916a5 test-mac-arm
[Finished] c48916a5 ursa-i9-9960x
[Finished] c48916a5 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@mapleFU @liujiacheng777
apacheGH-35279: [C++][Parquet] Tools: enhancement Parquet print stats (…
555c1b0 
…apache#35262)

### Rationale for this change

Enhancement printing value for parquet stats

### What changes are included in this PR?

1. Make DebugPrintStats for RecordReader better
2. Make Stats printer better

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: apache#35279

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@mapleFU @ArgusLi
apacheGH-35279: [C++][Parquet] Tools: enhancement Parquet print stats (…
c713493 
…apache#35262)

### Rationale for this change

Enhancement printing value for parquet stats

### What changes are included in this PR?

1. Make DebugPrintStats for RecordReader better
2. Make Stats printer better

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: apache#35279

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@mapleFU @rtpsw
apacheGH-35279: [C++][Parquet] Tools: enhancement Parquet print stats (…
7607416 
…apache#35262)

### Rationale for this change

Enhancement printing value for parquet stats

### What changes are included in this PR?

1. Make DebugPrintStats for RecordReader better
2. Make Stats printer better

### Are these changes tested?

No

### Are there any user-facing changes?

No

* Closes: apache#35279

Authored-by: mwish <maplewish117@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjones127 wjones127 wjones127 approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: C++ Component: Parquet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++][Parquet] Parquet File Print tools check statistics exists
3 participants
@mapleFU @wjones127 @ursabot