-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][GLib][Parquet] GParquetColumnChunkMetadata comparing failed #35266
Labels
Milestone
Comments
It seems that this is happen since we merge #35229. |
It's not reproduced on my local M1 macOS... |
kou
added a commit
to kou/arrow
that referenced
this issue
Apr 21, 2023
…ta_equal() test Because it's not stable on macOS. We omit the test for now like apacheGH-20207.
kou
added a commit
that referenced
this issue
Apr 22, 2023
…al() test (#35278) ### Rationale for this change Because it's not stable on macOS. ### What changes are included in this PR? We omit the test for now like GH-20207. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #35266 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
OK. Could you implement |
Okay, will add one today |
#35281 add one naive implemention |
kou
added a commit
to kou/arrow
that referenced
this issue
Apr 22, 2023
…erence is missing in sub metadata `GParquetColumnChunkMetadata` must not be GC-ed while the parent `GParquetRowGroupMetadata` is alive. `GParquetRowGroupMetadata` must not be GC-ed while the parent `GParquetFileMetadata` is alive.
kou
added a commit
that referenced
this issue
Apr 23, 2023
… is missing in sub metadata (#35286) ### Rationale for this change `GParquetColumnChunkMetadata` must not be GC-ed while the parent `GParquetRowGroupMetadata` is alive. `GParquetRowGroupMetadata` must not be GC-ed while the parent `GParquetFileMetadata` is alive. ### What changes are included in this PR? Add missing parent metadata references to sub metadata. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: #35266 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this issue
May 11, 2023
…ta_equal() test (apache#35278) ### Rationale for this change Because it's not stable on macOS. ### What changes are included in this PR? We omit the test for now like apacheGH-20207. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#35266 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this issue
May 11, 2023
…erence is missing in sub metadata (apache#35286) ### Rationale for this change `GParquetColumnChunkMetadata` must not be GC-ed while the parent `GParquetRowGroupMetadata` is alive. `GParquetRowGroupMetadata` must not be GC-ed while the parent `GParquetFileMetadata` is alive. ### What changes are included in this PR? Add missing parent metadata references to sub metadata. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#35266 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
…ta_equal() test (apache#35278) ### Rationale for this change Because it's not stable on macOS. ### What changes are included in this PR? We omit the test for now like apacheGH-20207. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#35266 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
…erence is missing in sub metadata (apache#35286) ### Rationale for this change `GParquetColumnChunkMetadata` must not be GC-ed while the parent `GParquetRowGroupMetadata` is alive. `GParquetRowGroupMetadata` must not be GC-ed while the parent `GParquetFileMetadata` is alive. ### What changes are included in this PR? Add missing parent metadata references to sub metadata. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#35266 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
…ta_equal() test (apache#35278) ### Rationale for this change Because it's not stable on macOS. ### What changes are included in this PR? We omit the test for now like apacheGH-20207. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#35266 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
…erence is missing in sub metadata (apache#35286) ### Rationale for this change `GParquetColumnChunkMetadata` must not be GC-ed while the parent `GParquetRowGroupMetadata` is alive. `GParquetRowGroupMetadata` must not be GC-ed while the parent `GParquetFileMetadata` is alive. ### What changes are included in this PR? Add missing parent metadata references to sub metadata. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#35266 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Describe the bug, including details regarding any error messages, version, and platform.
Eg:
Component(s)
Continuous Integration, Parquet, Ruby
The text was updated successfully, but these errors were encountered: