Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35315: [C++][CMake] Add presets for Flight SQL #35317

Merged
merged 1 commit into from
Apr 26, 2023
Merged

GH-35315: [C++][CMake] Add presets for Flight SQL #35317

merged 1 commit into from
Apr 26, 2023

Conversation

kou
Copy link
Member

@kou kou commented Apr 25, 2023 •
edited

Rationale for this change

The ninja-release-maximal preset doesn't enable Flight SQL.

What changes are included in this PR?

Add Flight SQL related presets.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@github-actions
Copy link

github-actions bot commented Apr 25, 2023 •
edited by kou

@github-actions
Copy link

⚠️ GitHub issue #35316 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Apr 25, 2023
@kou kou changed the title GH-35316: [C++][CMake] Add presets for Flight SQL GH-35315: [C++][CMake] Add presets for Flight SQL Apr 25, 2023
@github-actions
Copy link

⚠️ GitHub issue #35315 has been automatically assigned in GitHub to PR creator.

@kou kou merged commit 2444253 into apache:main Apr 26, 2023
31 of 35 checks passed
@kou kou deleted the cpp-cmake-preset-flight-sql branch April 26, 2023 00:23
@ursabot
Copy link

ursabot commented Apr 26, 2023

Benchmark runs are scheduled for baseline = 9588da9 and contender = 2444253. 2444253 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.36% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 24442530 ec2-t3-xlarge-us-east-2
[Failed] 24442530 test-mac-arm
[Finished] 24442530 ursa-i9-9960x
[Finished] 24442530 ursa-thinkcentre-m75q
[Finished] 9588da96 ec2-t3-xlarge-us-east-2
[Failed] 9588da96 test-mac-arm
[Finished] 9588da96 ursa-i9-9960x
[Finished] 9588da96 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@kou @liujiacheng777
apacheGH-35315: [C++][CMake] Add presets for Flight SQL (apache#35317)
4bd2cd2 
### Rationale for this change

The `ninja-release-maximal` preset doesn't enable Flight SQL.

### What changes are included in this PR?

Add Flight SQL related presets.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.

* Closes: apache#35315

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@kou @ArgusLi
apacheGH-35315: [C++][CMake] Add presets for Flight SQL (apache#35317)
e6bbac2 
### Rationale for this change

The `ninja-release-maximal` preset doesn't enable Flight SQL.

### What changes are included in this PR?

Add Flight SQL related presets.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.

* Closes: apache#35315

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@kou @rtpsw
apacheGH-35315: [C++][CMake] Add presets for Flight SQL (apache#35317)
5ae9e6c 
### Rationale for this change

The `ninja-release-maximal` preset doesn't enable Flight SQL.

### What changes are included in this PR?

Add Flight SQL related presets.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.

* Closes: apache#35315

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++][CMake] Add a preset that enables Flight SQL
3 participants
@kou @ursabot @lidavidm