[C++][FlightSQL] SQLite example server uses arrow::ArrayFromJSON #35316
Comments
kou
added a commit
to kou/arrow
that referenced
this issue
Apr 25, 2023
kou
added a commit
to kou/arrow
that referenced
this issue
Apr 25, 2023
…FromJSON() in SQLite example server Because ArrayFromJSON() requires arrow_testing. But cpp/examples/arrow/flight_sql_example.cc uses the SQLite example server without arrow_testing dependency.
kou
added a commit
to kou/arrow
that referenced
this issue
Apr 25, 2023
…FromJSON() in SQLite example server Because ArrayFromJSON() requires arrow_testing. But cpp/examples/arrow/flight_sql_example.cc uses the SQLite example server without arrow_testing dependency.
kou
added a commit
that referenced
this issue
Apr 26, 2023
…ON() in SQLite example server (#35322) ### Rationale for this change `ArrayFromJSON()` requires `libarrow_testing.so`. But `cpp/examples/arrow/flight_sql_example.cc` uses the SQLite example server without `libarrow_testing.so` dependency. ### What changes are included in this PR? Use `RowsToBatches()` in `libarrow.so` instead of `ArrayFromJSON()`. ### Are these changes tested? Yes by hand. ### Are there any user-facing changes? Yes. * Closes: #35316 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this issue
May 11, 2023
…FromJSON() in SQLite example server (apache#35322) ### Rationale for this change `ArrayFromJSON()` requires `libarrow_testing.so`. But `cpp/examples/arrow/flight_sql_example.cc` uses the SQLite example server without `libarrow_testing.so` dependency. ### What changes are included in this PR? Use `RowsToBatches()` in `libarrow.so` instead of `ArrayFromJSON()`. ### Are these changes tested? Yes by hand. ### Are there any user-facing changes? Yes. * Closes: apache#35316 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
…FromJSON() in SQLite example server (apache#35322) ### Rationale for this change `ArrayFromJSON()` requires `libarrow_testing.so`. But `cpp/examples/arrow/flight_sql_example.cc` uses the SQLite example server without `libarrow_testing.so` dependency. ### What changes are included in this PR? Use `RowsToBatches()` in `libarrow.so` instead of `ArrayFromJSON()`. ### Are these changes tested? Yes by hand. ### Are there any user-facing changes? Yes. * Closes: apache#35316 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
…FromJSON() in SQLite example server (apache#35322) ### Rationale for this change `ArrayFromJSON()` requires `libarrow_testing.so`. But `cpp/examples/arrow/flight_sql_example.cc` uses the SQLite example server without `libarrow_testing.so` dependency. ### What changes are included in this PR? Use `RowsToBatches()` in `libarrow.so` instead of `ArrayFromJSON()`. ### Are these changes tested? Yes by hand. ### Are there any user-facing changes? Yes. * Closes: apache#35316 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
It's a function included in
libarrow_testing.sonotlibarrow.so.We should not depend on
libarrow_testing.sobecause we don't requireARROW_BUILD_TESTS=ONforcpp/examples/arrow/flight_sql_example.cc.Component(s)
C++, FlightRPC
The text was updated successfully, but these errors were encountered: