Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35316: [C++][FlightSQL] Use RowsToBatches() instead of ArrayFromJSON() in SQLite example server #35322

Merged
merged 2 commits into from
Apr 26, 2023
Merged

GH-35316: [C++][FlightSQL] Use RowsToBatches() instead of ArrayFromJSON() in SQLite example server #35322

merged 2 commits into from
Apr 26, 2023

Conversation

kou
Copy link
Member

@kou kou commented Apr 25, 2023 •
edited by github-actions bot

Rationale for this change

ArrayFromJSON() requires libarrow_testing.so. But cpp/examples/arrow/flight_sql_example.cc uses the SQLite example server without libarrow_testing.so dependency.

What changes are included in this PR?

Use RowsToBatches() in libarrow.so instead of ArrayFromJSON().

Are these changes tested?

Yes by hand.

Are there any user-facing changes?

Yes.

@kou
apacheGH-35316: [C++][FlightSQL] Use RowsToBatches() instead of Array…
9f96570 
…FromJSON() in SQLite example server

Because ArrayFromJSON() requires arrow_testing. But
cpp/examples/arrow/flight_sql_example.cc uses the SQLite example
server without arrow_testing dependency.
@kou kou requested a review from lidavidm as a code owner April 25, 2023 09:03
@github-actions
Copy link

lidavidm
lidavidm approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@lidavidm lidavidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This is a bit complex though for what I would think is a common case. Perhaps we should consider some better utilities for this. (ADBC uses a column-wise, templated helper, though I suppose column-wise would also be messy here. https://github.com/apache/arrow-adbc/blob/a1dd00f88d76beaccfce000098d4cdb3944c015d/c/validation/adbc_validation_util.h#L304-L311)

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Apr 25, 2023
@kou
Copy link
Member Author

kou commented Apr 26, 2023

Perhaps we should consider some better utilities for this.

I agree with you.

@kou kou merged commit 797f346 into apache:main Apr 26, 2023
29 of 33 checks passed
@kou kou deleted the cpp-flight-sql-example-tests branch April 26, 2023 02:31
@ursabot
Copy link

ursabot commented Apr 26, 2023

Benchmark runs are scheduled for baseline = 2444253 and contender = 797f346. 797f346 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.12% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 797f3460 ec2-t3-xlarge-us-east-2
[Failed] 797f3460 test-mac-arm
[Finished] 797f3460 ursa-i9-9960x
[Finished] 797f3460 ursa-thinkcentre-m75q
[Finished] 24442530 ec2-t3-xlarge-us-east-2
[Failed] 24442530 test-mac-arm
[Finished] 24442530 ursa-i9-9960x
[Finished] 24442530 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@kou @liujiacheng777
apacheGH-35316: [C++][FlightSQL] Use RowsToBatches() instead of Array…
7192621 
…FromJSON() in SQLite example server (apache#35322)

### Rationale for this change

`ArrayFromJSON()` requires `libarrow_testing.so`. But `cpp/examples/arrow/flight_sql_example.cc` uses the SQLite example server without `libarrow_testing.so` dependency.

### What changes are included in this PR?

Use `RowsToBatches()` in `libarrow.so` instead of `ArrayFromJSON()`.

### Are these changes tested?

Yes by hand.

### Are there any user-facing changes?

Yes.
* Closes: apache#35316

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@kou @ArgusLi
apacheGH-35316: [C++][FlightSQL] Use RowsToBatches() instead of Array…
b0a43c2 
…FromJSON() in SQLite example server (apache#35322)

### Rationale for this change

`ArrayFromJSON()` requires `libarrow_testing.so`. But `cpp/examples/arrow/flight_sql_example.cc` uses the SQLite example server without `libarrow_testing.so` dependency.

### What changes are included in this PR?

Use `RowsToBatches()` in `libarrow.so` instead of `ArrayFromJSON()`.

### Are these changes tested?

Yes by hand.

### Are there any user-facing changes?

Yes.
* Closes: apache#35316

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@kou @rtpsw
apacheGH-35316: [C++][FlightSQL] Use RowsToBatches() instead of Array…
42c94ce 
…FromJSON() in SQLite example server (apache#35322)

### Rationale for this change

`ArrayFromJSON()` requires `libarrow_testing.so`. But `cpp/examples/arrow/flight_sql_example.cc` uses the SQLite example server without `libarrow_testing.so` dependency.

### What changes are included in this PR?

Use `RowsToBatches()` in `libarrow.so` instead of `ArrayFromJSON()`.

### Are these changes tested?

Yes by hand.

### Are there any user-facing changes?

Yes.
* Closes: apache#35316

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
awaiting merge Awaiting merge Component: C++ Component: FlightRPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[C++][FlightSQL] SQLite example server uses arrow::ArrayFromJSON
3 participants
@kou @ursabot @lidavidm