Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35425: [R] Tests failures on R < 4.0 due to data.frame conversion #35432

Merged
merged 2 commits into from
May 11, 2023
Merged

GH-35425: [R] Tests failures on R < 4.0 due to data.frame conversion #35432

merged 2 commits into from
May 11, 2023

Conversation

thisisnic
Copy link
Member

@thisisnic thisisnic commented May 4, 2023 •
edited by github-actions bot
Loading

@thisisnic
Copy link
Member Author

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

github-actions bot commented May 4, 2023

@github-actions github-actions bot added Component: R awaiting committer review Awaiting committer review labels May 4, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

Revision: 4f831f6

Submitted crossbow builds: ursacomputing/crossbow @ actions-05746f9399

Task Status
test-r-versions Github Actions

@thisisnic
Copy link
Member Author

@github-actions crossbow submit test-r-versions

@github-actions
Copy link

github-actions bot commented May 4, 2023

Revision: aea7914

Submitted crossbow builds: ursacomputing/crossbow @ actions-46ca612034

Task Status
test-r-versions Github Actions

@thisisnic thisisnic merged commit 11780b9 into apache:main May 11, 2023
@ursabot
Copy link

ursabot commented May 11, 2023

Benchmark runs are scheduled for baseline = 3948c42 and contender = 11780b9. 11780b9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️2.41% ⬆️0.09%] test-mac-arm
[Finished ⬇️0.25% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.81% ⬆️0.09%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 11780b96 ec2-t3-xlarge-us-east-2
[Finished] 11780b96 test-mac-arm
[Finished] 11780b96 ursa-i9-9960x
[Finished] 11780b96 ursa-thinkcentre-m75q
[Finished] 3948c426 ec2-t3-xlarge-us-east-2
[Finished] 3948c426 test-mac-arm
[Finished] 3948c426 ursa-i9-9960x
[Finished] 3948c426 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 11, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@thisisnic @ArgusLi
apacheGH-35425: [R] Tests failures on R < 4.0 due to data.frame conve…
ba5fea0 
…rsion (apache#35432)

* Closes: apache#35425

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@thisisnic @rtpsw
apacheGH-35425: [R] Tests failures on R < 4.0 due to data.frame conve…
a24929b 
…rsion (apache#35432)

* Closes: apache#35425

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
@thisisnic thisisnic mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleolimbot paleolimbot Awaiting requested review from paleolimbot

Assignees
No one assigned
Labels
awaiting committer review Awaiting committer review Component: R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[R] Tests failures on R < 4.0 due to data.frame conversion
2 participants
@thisisnic @ursabot