Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35425: [R] Tests failures on R < 4.0 due to data.frame conversion #35432

Merged
merged 2 commits into from
May 11, 2023
Merged

GH-35425: [R] Tests failures on R < 4.0 due to data.frame conversion #35432

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f831f6
Set stringsAsFactors to FALSE in data.frame conversions
thisisnic May 4, 2023
aea7914
Move stringsAsFactors=FALSE to where needed
thisisnic May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion r/tests/testthat/test-dataset-csv.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ test_that("CSV scan options", {
sb$FragmentScanOptions(options)

tab <- sb$Finish()$ToTable()
expect_equal_data_frame(tab, data.frame(chr = c("foo", NA)))
expect_equal_data_frame(tab, data.frame(chr = c("foo", NA), stringsAsFactors = FALSE))

# Set default convert options in CsvFileFormat
csv_format <- CsvFileFormat$create(
Expand Down