Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35709: [R][Documentation] Document passing data to duckdb for windowed aggregates #35882

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

dgreiss
Copy link
Contributor

@dgreiss dgreiss commented Jun 2, 2023

Rationale for this change

#35702 documents how to use joins for computing windowed aggregates. This documents an alternative solution by passing data to duckdb. This use case was also mentioned on the duckdb blog.

What changes are included in this PR?

Changes to vignette.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

⚠️ GitHub issue #35709 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this PR! This looks good - one addition to suggest; would you mind adding in a call to to_arrow() in the code example? It's not technically needed before the collect(), but it'd be helpful to make users aware of it in case they have pipelines where they want to run more code in Arrow before pulling the data into memory.

@dgreiss
Copy link
Contributor Author

dgreiss commented Jun 4, 2023

I rebased and I think I cleaned up this PR. Let me know if there are any other changes needed

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jun 5, 2023
@thisisnic thisisnic merged commit dd26757 into apache:main Jun 7, 2023
@ursabot
Copy link

ursabot commented Jun 8, 2023

Benchmark runs are scheduled for baseline = a0d28de and contender = dd26757. dd26757 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.59% ⬆️0.06%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.54% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] dd267572 ec2-t3-xlarge-us-east-2
[Finished] dd267572 test-mac-arm
[Finished] dd267572 ursa-i9-9960x
[Finished] dd267572 ursa-thinkcentre-m75q
[Finished] a0d28dee ec2-t3-xlarge-us-east-2
[Finished] a0d28dee test-mac-arm
[Finished] a0d28dee ursa-i9-9960x
[Finished] a0d28dee ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@dgreiss dgreiss deleted the gh-35709-doc-updates branch June 18, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[R] Add mention of moving data to/from DuckDB to the vignettes
3 participants