-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-35709: [R][Documentation] Document passing data to duckdb for windowed aggregates #35882
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR! This looks good - one addition to suggest; would you mind adding in a call to to_arrow()
in the code example? It's not technically needed before the collect()
, but it'd be helpful to make users aware of it in case they have pipelines where they want to run more code in Arrow before pulling the data into memory.
84634a5
to
116c57c
Compare
116c57c
to
f80ac82
Compare
I rebased and I think I cleaned up this PR. Let me know if there are any other changes needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thanks!
Benchmark runs are scheduled for baseline = a0d28de and contender = dd26757. dd26757 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Rationale for this change
#35702 documents how to use joins for computing windowed aggregates. This documents an alternative solution by passing data to duckdb. This use case was also mentioned on the duckdb blog.
What changes are included in this PR?
Changes to vignette.