Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35909: [Go] Deprecate arrow.MapType.ValueField & arrow.MapType.ValueType methods #35899

Merged
merged 3 commits into from
Jun 6, 2023

Conversation

candiduslynx
Copy link
Contributor

@candiduslynx candiduslynx commented Jun 4, 2023

Rationale for this change

Follow-up for #35885

What changes are included in this PR?

  • Added ElemField() Field to arrow.ListLikeType interface
  • Added ElemField() Field to arrow.MapType implementation
  • Added deprecation notice to arrow.MapType.ValueField & arrow.MapType.ValueType
  • Fixed a bug in go/arrow/array/map.go (NewMapBuilderWithType used ValueType instead of ItemType)

Are these changes tested?

Compile-time assertion for corresponding types.

Are there any user-facing changes?

  • Added ElemField() Field to arrow.ListLikeType interface
  • Added ElemField() Field to arrow.MapType implementation
  • Added deprecation notice to arrow.MapType.ValueField & arrow.MapType.ValueType

@candiduslynx
Copy link
Contributor Author

candiduslynx commented Jun 4, 2023

@zeroshade I've marked the ValueX methods of MapType deprecated.
It also highlighted 1 bug in go/arrow/array/map.go (NewMapBuilderWithType used ValueType instead of ItemType)

@candiduslynx candiduslynx changed the title MINOR: [Go] Add ElemField() Field to arrow.ListLikeType interface GH-35909: [Go] Deprecate arrow.MapType.ValueField & arrow.MapType.ValueType methods Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

⚠️ GitHub issue #35909 has been automatically assigned in GitHub to PR creator.

@candiduslynx
Copy link
Contributor Author

@zeroshade any chance to get an initial review today?

Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one nit

go/parquet/pqarrow/encode_arrow.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Jun 6, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 6, 2023
@zeroshade zeroshade merged commit daacbcc into apache:main Jun 6, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Jun 6, 2023
@candiduslynx candiduslynx deleted the chore/extend/list-like-type branch June 6, 2023 18:22
@ursabot
Copy link

ursabot commented Jun 8, 2023

Benchmark runs are scheduled for baseline = 77d8bc5 and contender = daacbcc. daacbcc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.44% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.33% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.3% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] daacbcc4 ec2-t3-xlarge-us-east-2
[Finished] daacbcc4 test-mac-arm
[Finished] daacbcc4 ursa-i9-9960x
[Finished] daacbcc4 ursa-thinkcentre-m75q
[Finished] 77d8bc59 ec2-t3-xlarge-us-east-2
[Finished] 77d8bc59 test-mac-arm
[Finished] 77d8bc59 ursa-i9-9960x
[Finished] 77d8bc59 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate arrow.MapType.ValueField & arrow.MapType.ValueType methods
3 participants