GH-35868: [C++] Occasional TSAN failure on asof-join-node-test

[rtpsw]

Rationale for this change

AsofJoinNode may run into a data race when invalidating the key hasher.

The key hasher queried from one thread but invalidated from another. This might be simplified so that the key hasher would only be used from one thread, but this is out of scope for this PR.

What changes are included in this PR?

The invalidated member of the key hasher is made atomic.

Are these changes tested?

Yes, by existing testing.

Are there any user-facing changes?

No.

• Closes: [C++] Occasional TSAN failure on asof-join-node-test #35868

[github-actions]

⚠️ GitHub issue #35868 has been automatically assigned in GitHub to PR creator.

[rtpsw]

cc @pitrou

[github-actions]

⚠️ GitHub issue #35868 has been automatically assigned in GitHub to PR creator.

[pitrou]

Adjusted your PR description to add the explanation you gave in 380aa94#r1218255714

[pitrou]

@github-actions crossbow submit test-ubuntu-20.04-cpp-thread-sanitizer

[github-actions]

Revision: 0ceff4d

Submitted crossbow builds: ursacomputing/crossbow @ actions-487d9b0cb0

Task	Status
test-ubuntu-20.04-cpp-thread-sanitizer

[ursabot]

Benchmark runs are scheduled for baseline = e2ae492 and contender = c253625. c253625 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.39% ⬆️0.03%] test-mac-arm
[Failed] ursa-i9-9960x
[Failed ⬇️0.33% ⬆️0.06%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] c2536253 ec2-t3-xlarge-us-east-2
[Failed] c2536253 test-mac-arm
[Failed] c2536253 ursa-i9-9960x
[Failed] c2536253 ursa-thinkcentre-m75q
[Failed] e2ae492b ec2-t3-xlarge-us-east-2
[Failed] e2ae492b test-mac-arm
[Failed] e2ae492b ursa-i9-9960x
[Failed] e2ae492b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java