Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-35911: [Go] Fix method CastToBytes of decimal256Traits #35912

Merged
merged 1 commit into from
Jun 6, 2023
Merged

GH-35911: [Go] Fix method CastToBytes of decimal256Traits #35912

merged 1 commit into from
Jun 6, 2023

Conversation

izveigor
Copy link
Contributor

@izveigor izveigor commented Jun 5, 2023

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Yes

Are there any user-facing changes?

Yes

@izveigor izveigor requested a review from zeroshade as a code owner June 5, 2023 14:08
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

⚠️ GitHub issue #35911 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@zeroshade zeroshade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 5, 2023
@zeroshade zeroshade merged commit 4ec231b into apache:main Jun 6, 2023
21 checks passed
@ursabot
Copy link

ursabot commented Jun 6, 2023

Benchmark runs are scheduled for baseline = 3d0172d and contender = 4ec231b. 4ec231b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Failed] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.74% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.27% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Failed] 4ec231b2 ec2-t3-xlarge-us-east-2
[Failed] 4ec231b2 test-mac-arm
[Finished] 4ec231b2 ursa-i9-9960x
[Failed] 4ec231b2 ursa-thinkcentre-m75q
[Failed] 3d0172d4 ec2-t3-xlarge-us-east-2
[Failed] 3d0172d4 test-mac-arm
[Finished] 3d0172d4 ursa-i9-9960x
[Failed] 3d0172d4 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

method CastToBytes of decimal256Traits does not work
3 participants