MINOR: [CI] Bump actions/setup-go from 3 to 4

[dependabot]

Bumps actions/setup-go from 3 to 4.

Release notes

Sourced from actions/setup-go's releases.

v4.0.0

In scope of release we enable cache by default. The action won’t throw an error if the cache can’t be restored or saved. The action will throw a warning message but it won’t stop a build process. The cache can be disabled by specifying cache: false.

steps:
  - uses: actions/checkout@v3
  - uses: actions/setup-go@v4
    with:
      go-version: ‘1.19’
  - run: go run hello.go

Besides, we introduce such changes as

• Allow to use only GOCACHE for cache
• Bump json5 from 2.2.1 to 2.2.3
• Use proper version for primary key in cache
• Always add Go bin to the PATH
• Add step warning if go-version input is empty

Add support for stable and oldstable aliases

In scope of this release we introduce aliases for the go-version input. The stable alias instals the latest stable version of Go. The oldstable alias installs previous latest minor release (the stable is 1.19.x -> the oldstable is 1.18.x).

Stable

steps:
  - uses: actions/checkout@v3
  - uses: actions/setup-go@v3
    with:
      go-version: 'stable'
  - run: go run hello.go

OldStable

steps:
  - uses: actions/checkout@v3
  - uses: actions/setup-go@v3
    with:
      go-version: 'oldstable'
  - run: go run hello.go

Add support for go.work and pass the token input through on GHES

In scope of this release we added support for go.work file to pass it in go-version-file input.

steps:
  - uses: actions/checkout@v3
  - uses: actions/setup-go@v3
</tr></table> 

... (truncated)

Commits

• fac708d Bump @​actions/cache dependency to v3.2.1 (#374)
• dd84a95 Update xml2js (#370)
• 41c2024 Fix glob bug in package.json scripts section (#359)
• 8dbf352 update README fo v4 (#354)
• 4d34df0 Update configuration files (#348)
• fdc0d67 Add Go bin if go-version input is empty (#351)
• ebfdf6a add warning if go-version is empty (#350)
• b27d769 fix lockfileVersion (#349)
• c51a720 Enable caching by default with default input (#332)
• 6b848af Merge pull request #343 from akv-platform/reusable-workflow
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[raulcd]

Some of the failures are related to the benchmark tests here:

 Traceback (most recent call last):
  File "/Users/runner/work/arrow/arrow/ci/scripts/go_bench_adapt.py", line 52, in <module>
    assert os.getenv("GITHUB_ACTIONS") is None
AssertionError

Is there any reason we are raising an AssertionError here?
@zeroshade @jgehrcke

[jgehrcke]

Is there any reason we are raising an AssertionError here?

Yes, this code is not supposed to execute in GHA for a non-default branch:

arrow/ci/scripts/go_bench_adapt.py

Line 46 in e6221c4

"pr_number": None, # implying default branch

else:
    # Assume that the environment is not GitHub Actions CI. Error out if that
    # assumption seems to be wrong.
    assert os.getenv("GITHUB_ACTIONS") is None

    # This is probably a local dev environment, for testing. In this case, it
    # does usually not make sense to provide commit information (not a
    # controlled CI environment). Explicitly keep `github_commit_info=None` to
    # reflect that (to not send commit information).

In that sense I think the failure is expected and does / should not block merge. If the redness is a problem then we can also sys.exit(0) instead. Although that might result in mean false-positive green signal in the future.

[raulcd]

Ok, I think the problem is that the PR from dependabot is coming from a branch on the apache/arrow repository instead of a fork hence those are executed which are not if they are from a fork branch due to:
if: success() && github.event_name == 'push' && github.repository == 'apache/arrow'
Probably we should not error and just do a sys.exit(0) but now I understand why this is failing here.

[kou]

I've opened a new issue for it: #36218

[assignUser]

I see no breaking changes in v4 and the jobs succeed outside of the benchmarking issue.

[kou]

@dependabot rebase

[kou]

+1

[conbench-apache-arrow]

Conbench analyzed the 6 benchmark runs on commit 320ecbd1.

There were 5 benchmark results indicating a performance regression:

• Commit Run on ursa-i9-9960x at 2023-06-24 20:10:19Z
  • compression=uncompressed, dataset=fanniemae_2016Q4, file_type=feather, language=R, output_type=table
  • compression=uncompressed, dataset=fanniemae_2016Q4, file_type=feather, language=R, output_type=dataframe
• and 3 more (see the report linked below)

The full Conbench report has more details.