GH-35450: [C++] Return error when RecordBatch::ToStructArray
called with mismatched column lengths
#36654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
If a
RecordBatch
is created with column lengths that don't match the providednum_rows
(technically invalid), then there are some circumstances whereToStructArray
will successfully return an array whose length doesn't matchnum_rows
. Instead, we should return an error.What changes are included in this PR?
ToStructArray
before constructing the output arrayAre these changes tested?
Yes (tests are included)
Are there any user-facing changes?
No