GH-36860: [C++] Report CMake error when system Protobuf exists but system gRPC doesn't exist #36904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but system gRPC doesn't exist
|
|
github-actions
bot
added
Component: C++
awaiting committer review
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 0f29147. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
R-JunmingChen
pushed a commit
to R-JunmingChen/arrow
that referenced
this pull request
Aug 20, 2023
…but system gRPC doesn't exist (apache#36904) ### Rationale for this change We require system gRPC when system Protobuf is found to avoid underlying library (Abseil) mismatch. We should report it as an error on `cmake...` time instead of build time. ### What changes are included in this PR? Always call `find_package_handle_standard_args()` to report an error for the case. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#36860 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: David Li <li.davidm96@gmail.com>
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…but system gRPC doesn't exist (apache#36904) ### Rationale for this change We require system gRPC when system Protobuf is found to avoid underlying library (Abseil) mismatch. We should report it as an error on `cmake...` time instead of build time. ### What changes are included in this PR? Always call `find_package_handle_standard_args()` to report an error for the case. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#36860 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We require system gRPC when system Protobuf is found to avoid underlying library (Abseil) mismatch. We should report it as an error on
cmake...time instead of build time.What changes are included in this PR?
Always call
find_package_handle_standard_args()to report an error for the case.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.