GH-37245: [MATLAB] arrow.internal.proxy.validate throws MATLAB:UndefinedFunction when crafting the message to display when throwing the arrow:proxy:ProxyNameMismatch error
#37248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kevingurney
changed the title
arrow.internal.proxy.validate throws an MATLAB:UndefinedFunction when crafting the message to display when throwing the arrow:proxy:ProxyNameMismatch error arrow.internal.proxy.validate throws MATLAB:UndefinedFunction when crafting the message to display when throwing the arrow:proxy:ProxyNameMismatch error
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit fc96fd2. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…AB:UndefinedFunction` when crafting the message to display when throwing the `arrow:proxy:ProxyNameMismatch` error (apache#37248) ### Rationale for this change When constructing the message to display for with the `arrow:proxy:ProxyNameMismatch` error, we refer to an undefined variable in `arrow.internal.proxy.validate()`. This causes the function to throw a `MATLAB:UndefinedFunction` error instead of the intended one. Here's an example of this bug: ```matlab >> a = arrow.array([1 2 3]); >> arrow.internal.proxy.validate(a.Proxy, "WrongProxyName") Unrecognized function or variable 'proxyName'. Error in arrow.internal.proxy.validate (line 26) msg = "Proxy class name is " + proxyName + ", but expected " + expectedProxyName; ``` This was the expected error message: ```matlab >> a = arrow.array([1 2 3]); >> arrow.internal.proxy.validate(a.Proxy, "WrongProxyName") Error using arrow.internal.proxy.validate Proxy class name is arrow.array.proxy.Float64Array, but expected WrongProxyName ``` ### What changes are included in this PR? 1. Fixed the typos in `arrow.internal.proxy.validate()` to resolve the `MATLAB:UndefinedFunction` error 2. Added a new test class `test/arrow/internal/proxy/tValidate.m` to test `arrow.internal.proxy.validate()` 3. Updated the error message to display when throwing an `arrow:proxy:ProxyNameMismatch` error: ```matlab >> a = arrow.array([1 2 3]); >> arrow.internal.proxy.validate(a.Proxy, "WrongProxyName") Error using arrow.internal.proxy.validate The Name property of the Proxy provided is "arrow.array.proxy.Float64Array", but expected it to be "WrongProxyName". ``` ### Are these changes tested? Yes, added a new test class `test/arrow/internal/proxy/tValidate.m`. ### Are there any user-facing changes? No. * Closes: apache#37245 Authored-by: Sarah Gilmore <sgilmore@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When constructing the message to display for with the
arrow:proxy:ProxyNameMismatcherror, we refer to an undefined variable inarrow.internal.proxy.validate(). This causes the function to throw aMATLAB:UndefinedFunctionerror instead of the intended one.Here's an example of this bug:
This was the expected error message:
What changes are included in this PR?
arrow.internal.proxy.validate()to resolve theMATLAB:UndefinedFunctionerrortest/arrow/internal/proxy/tValidate.mto testarrow.internal.proxy.validate()arrow:proxy:ProxyNameMismatcherror:Are these changes tested?
Yes, added a new test class
test/arrow/internal/proxy/tValidate.m.Are there any user-facing changes?
No.
arrow.internal.proxy.validatethrows anMATLAB:UndefinedFunctionwhen crafting the message to display when throwing thearrow:proxy:ProxyNameMismatcherror #37245