Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-37245: [MATLAB] arrow.internal.proxy.validate throws MATLAB:UndefinedFunction when crafting the message to display when throwing the arrow:proxy:ProxyNameMismatch error #37248

Merged
merged 3 commits into from
Aug 18, 2023
Merged

GH-37245: [MATLAB] arrow.internal.proxy.validate throws MATLAB:UndefinedFunction when crafting the message to display when throwing the arrow:proxy:ProxyNameMismatch error #37248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0bb3386
Fix UndefinedFunction error in arrow.internal.proxy.validate
sgilmore10 Aug 18, 2023
04157cc
Add tests class for arrow.internal.proxy.validate()
sgilmore10 Aug 18, 2023
f636bcb
Remove extra spaces
sgilmore10 Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions matlab/src/matlab/+arrow/+internal/+proxy/validate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,13 @@ function validate(proxy, expectedName)
% proxy.Name and expectedName are not equal.
arguments
proxy(1, 1) libmexclass.proxy.Proxy
expectedName(1, 1) string
expectedName(1, 1) string {mustBeNonmissing, mustBeNonzeroLengthText}
end

if proxy.Name ~= expectedName
errid = "arrow:proxy:ProxyNameMismatch";
msg = "Proxy class name is " + proxyName + ", but expected " + expectedProxyName;
msg = compose("The Name property of the Proxy provided is ""%s"", " + ...
"but expected it to be ""%s"".", proxy.Name, expectedName);
error(errid, msg);
end
end
42 changes: 42 additions & 0 deletions matlab/test/arrow/internal/proxy/tValidate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
%TVALIDATE Unit tests for arrow.internal.proxy.validate

% Licensed to the Apache Software Foundation (ASF) under one or more
% contributor license agreements. See the NOTICE file distributed with
% this work for additional information regarding copyright ownership.
% The ASF licenses this file to you under the Apache License, Version
% 2.0 (the "License"); you may not use this file except in compliance
% with the License. You may obtain a copy of the License at
%
% http://www.apache.org/licenses/LICENSE-2.0
%
% Unless required by applicable law or agreed to in writing, software
% distributed under the License is distributed on an "AS IS" BASIS,
% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
% implied. See the License for the specific language governing
% permissions and limitations under the License.

classdef tValidate < matlab.unittest.TestCase

methods(Test)
function ProxyNameMatches(testCase)
% Verify arrow.internal.proxy.validate() does not throw an
% error if the Name property of the Proxy provided matches
% the expected proxy name.
import arrow.internal.proxy.validate
a = arrow.array(1);
fcn = @() validate(a.Proxy, a.Proxy.Name);
testCase.verifyWarningFree(fcn);
end

function ProxyNameMismatchError(testCase)
% Verify arrow.internal.proxy.validate() throws an error
% whose identifier is "arrow:proxy:ProxyNameMismatch" if the
% Name property of the Proxy provided does not match the
% expected proxy name.
import arrow.internal.proxy.validate
a = arrow.array(1);
fcn = @() validate(a.Proxy, "NotAProxyName");
testCase.verifyError(fcn, "arrow:proxy:ProxyNameMismatch");
end
end
end