Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-37978: [C++] Add support for specifying custom Array element delimiter to arrow::PrettyPrintOptions #37981

Merged
merged 12 commits into from
Oct 5, 2023
Merged

GH-37978: [C++] Add support for specifying custom Array element delimiter to arrow::PrettyPrintOptions #37981

merged 12 commits into from
Oct 5, 2023

Commits on Oct 2, 2023

  1. Add array_element_delimiter option to PrettyPrintOptions class.

    @kevingurney
    kevingurney committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    d08fe8b View commit details
    Browse the repository at this point in the history

  2. Add PrimitiveTypeCustomArrayElementDelimiter test.

    @kevingurney
    kevingurney committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    883a346 View commit details
    Browse the repository at this point in the history

  3. Add ChunkedArrayPrimitiveTypeCustomArrayDelimiter test.

    @kevingurney
    kevingurney committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    5ed5b0f View commit details
    Browse the repository at this point in the history

  4. 1. Fix linting errors. 

    2. Fix typo. ChunkedArrayPrimitiveTypeCustomArrayDelimiter -> ChunkedArrayPrimitiveTypeCustomArrayElementDelimiter.
    @kevingurney
    kevingurney committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    641cfb3 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Fix C++ linting errors by applying @kou's patch.

    @kevingurney
    kevingurney committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    fd5aaf2 View commit details
    Browse the repository at this point in the history

  2. Update delimiter tests to use default values for window and `skip_n… 

    …ew_lines` properties.
    @kevingurney
    kevingurney committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    6fe19f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Add PrettyPrintDelimiters struct and add array_delimiters and 

    `chunked_array_delimiters` properties to `PrettyPrintOptions` struct
based on @kou's suggestion.
    @kevingurney
    kevingurney committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    da353b9 View commit details
    Browse the repository at this point in the history

  2. 1. Fix syntax errors. 

    2. Update tests.
    @kevingurney
    kevingurney committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    72f6447 View commit details
    Browse the repository at this point in the history

  3. Use options.array_delimiters.element instead of `array_element_deli… 

    …miter`.
    @kevingurney
    kevingurney committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    573872b View commit details
    Browse the repository at this point in the history

  4. Update tests.

    @kevingurney
    kevingurney committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    fc24e03 View commit details
    Browse the repository at this point in the history

  5. Fix clang-format linting errors.

    @kevingurney
    kevingurney committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    f30e433 View commit details
    Browse the repository at this point in the history

  6. Fix typo.

    @kevingurney
    kevingurney committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    eedee47 View commit details
    Browse the repository at this point in the history