Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-37996: [MATLAB] Add a static constructor method named fromMATLAB to arrow.array.StructArray #37998

Merged
merged 7 commits into from
Oct 3, 2023
Merged

GH-37996: [MATLAB] Add a static constructor method named fromMATLAB to arrow.array.StructArray #37998

merged 7 commits into from
Oct 3, 2023

Commits on Oct 3, 2023

  1. Add fromMATLAB static method to arrow.array.StructArray

    @sgilmore10
    sgilmore10 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    b2cf685 View commit details
    Browse the repository at this point in the history

  2. Add comments to arrow.array.StructArray fromMATLAB method

    @sgilmore10
    sgilmore10 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    2faeea1 View commit details
    Browse the repository at this point in the history

  3. Set ArrayStaticConstructor property of StructTraits to 

    @arrow.array.StructArray.fromMATLAB
    @sgilmore10
    sgilmore10 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    26a9605 View commit details
    Browse the repository at this point in the history

  4. Return StructTraits from arrow.type.traits.traits(className) when 

    className is the string "table"
    @sgilmore10
    sgilmore10 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    dca42ca View commit details
    Browse the repository at this point in the history

  5. Add StructArray support to arrow.array

    @sgilmore10
    sgilmore10 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    ffc299d View commit details
    Browse the repository at this point in the history

  6. Add tests for arrow.array.StructArray.fromMATLAB and arrow.array

    @sgilmore10
    sgilmore10 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    2b03c3f View commit details
    Browse the repository at this point in the history

  7. Address code review feedback

    @sgilmore10
    sgilmore10 committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    3fa8bde View commit details
    Browse the repository at this point in the history