-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39050: [C++] Use Cast() instead of CastTo() for Timestamp Scalar in test #39060
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit c39a223. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them. |
…est (#39226) ### Rationale for this change Remove legacy code This is a sub-PR of the PR mentioned below. * #39060 ### What changes are included in this PR? * Replace the legacy scalar `CastTo` implementation for Timestamp Scalar in test. It was supposed to be resolved in the mentioned PR, but it was missed. ### Are these changes tested? Yes. It is passed by existing test cases. ### Are there any user-facing changes? No. Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…est (apache#39226) ### Rationale for this change Remove legacy code This is a sub-PR of the PR mentioned below. * apache#39060 ### What changes are included in this PR? * Replace the legacy scalar `CastTo` implementation for Timestamp Scalar in test. It was supposed to be resolved in the mentioned PR, but it was missed. ### Are these changes tested? Yes. It is passed by existing test cases. ### Are there any user-facing changes? No. Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…alar in test (apache#39060) ### Rationale for this change Remove legacy code ### What changes are included in this PR? * Replace the legacy scalar CastTo implementation for Timestamp Scalar in test. The cast function already supports casting between different timestamp types. We just need to allow for the possibility of data loss by using `CastOptions::Unsafe()`. ### Are these changes tested? Yes. It is passed by existing test cases. ### Are there any user-facing changes? No. * Closes: apache#39050 Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
…est (apache#39226) ### Rationale for this change Remove legacy code This is a sub-PR of the PR mentioned below. * apache#39060 ### What changes are included in this PR? * Replace the legacy scalar `CastTo` implementation for Timestamp Scalar in test. It was supposed to be resolved in the mentioned PR, but it was missed. ### Are these changes tested? Yes. It is passed by existing test cases. ### Are there any user-facing changes? No. Authored-by: Hyunseok Seo <hsseo0501@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Rationale for this change
Remove legacy code
What changes are included in this PR?
CastOptions::Unsafe()
.Are these changes tested?
Yes. It is passed by existing test cases.
Are there any user-facing changes?
No.