You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
…n test (#39060)
### Rationale for this change
Remove legacy code
### What changes are included in this PR?
* Replace the legacy scalar CastTo implementation for Timestamp Scalar in test. The cast function already supports casting between different timestamp types. We just need to allow for the possibility of data loss by using `CastOptions::Unsafe()`.
### Are these changes tested?
Yes. It is passed by existing test cases.
### Are there any user-facing changes?
No.
* Closes: #39050
Authored-by: Hyunseok Seo <hsseo0501@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
kou
changed the title
[C++] Add Compute Kernel for Casting between Different Timestamp Types
[C++] Add Compute Kernel for Casting between Different Timestamp Types
Dec 5, 2023
…alar in test (apache#39060)
### Rationale for this change
Remove legacy code
### What changes are included in this PR?
* Replace the legacy scalar CastTo implementation for Timestamp Scalar in test. The cast function already supports casting between different timestamp types. We just need to allow for the possibility of data loss by using `CastOptions::Unsafe()`.
### Are these changes tested?
Yes. It is passed by existing test cases.
### Are there any user-facing changes?
No.
* Closes: apache#39050
Authored-by: Hyunseok Seo <hsseo0501@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Describe the enhancement requested
This is a sub-issue of the issue mentioned below.
As we can see in the parent issue, we can find tables organizing the related functions.
TimestampScalar(value, timestamp(in)).CastTo(timestamp(out)).ValueOrDie();
TimestampScalar(1024, timestamp(TimeUnit::MILLI)).CastTo(utf8()));
TimestampScalar(1024, timestamp(TimeUnit::MILLI)).CastTo(int64()));
.CastTo(date64()));
We need to implement casting between different
Timestamp
types.scalar_test.cc
Snippet to reproduce
Component(s)
C++
The text was updated successfully, but these errors were encountered: