GH-39257: [JS] LargeBinary #39258
Merged
GH-39257: [JS] LargeBinary #39258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: JavaScript
Component: Documentation
awaiting committer review
bmschmidt
reviewed
Dec 17, 2023
Comment on lines
+39
to
+54
| protected _flushPending(pending: Map<number, Uint8Array | undefined>, pendingLength: number) { | ||
| const offsets = this._offsets; | ||
| const data = this._values.reserve(pendingLength).buffer; | ||
| let offset = 0; | ||
| for (const [index, value] of pending) { | ||
| if (value === undefined) { | ||
| offsets.set(index, BigInt(0)); | ||
| } else { | ||
| const length = value.length; | ||
| data.set(value, offset); | ||
| offsets.set(index, BigInt(length)); | ||
| offset += length; | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Do you want to activate the placeholder in builder/largeutf8.ts in this PR?
Seems like you could probably do the same for getByteLength, too.
(LargeUtf8Builder.prototype as any)._flushPending = (LargeBinaryBuilder.prototype as any)._flushPending;
There was a problem hiding this comment.
Yes, just updated the pull request.
bmschmidt
approved these changes
Dec 17, 2023
|
Oh good catch. I forgot to remove that duplicate code. |
|
CC @kylebarron |
github-actions
bot
added
awaiting changes
This was referenced Dec 18, 2023
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 4ec6544. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 7 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This was referenced Jan 4, 2024
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
Merge after apache#39249 * Closes: apache#39257
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
Merge after apache#39249 * Closes: apache#39257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #39249