-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39248: [JS] Unify code paths for utf8 and largeUtf8 #39249
Conversation
@ursabot please benchmark lang=JavaScript |
Benchmark runs are scheduled for commit 4da251b. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be posted here when the runs are complete. |
Thanks for your patience. Conbench analyzed the 1 benchmarking run that has been run so far on PR commit 4da251b. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Reviewed as part of #39258. |
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 9c097d5. There were 2 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…39249) Reduce the code size by using common code paths. We only call `Number` a few times on numbers, which should be a noop. * Closes: apache#39248
Merge after apache#39249 * Closes: apache#39257
…39249) Reduce the code size by using common code paths. We only call `Number` a few times on numbers, which should be a noop. * Closes: apache#39248
Merge after apache#39249 * Closes: apache#39257
Reduce the code size by using common code paths. We only call
Number
a few times on numbers, which should be a noop.