Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39425: [CI] Fix import to match new substrait repo structure #39426

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jan 2, 2024

Rationale for this change

Upstream substrait repo did a small refactor. We have to update our imports to match the new structure.

What changes are included in this PR?

Update import

Are these changes tested?

Via archery

Are there any user-facing changes?

No

Copy link

github-actions bot commented Jan 2, 2024

⚠️ GitHub issue #39425 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented Jan 2, 2024

@github-actions crossbow submit test-conda-python-3.10-substrait

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 2, 2024
Copy link

github-actions bot commented Jan 2, 2024

Revision: 1d0226a

Submitted crossbow builds: ursacomputing/crossbow @ actions-d7862e96be

Task Status
test-conda-python-3.10-substrait GitHub Actions

@raulcd
Copy link
Member Author

raulcd commented Jan 2, 2024

@richtia @vibhatha is the AceroConsumer on https://github.com/substrait-io/consumer-testing not supposed to work anymore?

 pytest: error: argument --consumer: invalid choice: 'AceroConsumer' (choose from 'DataFusionConsumer', 'DuckDBConsumer')

Should we remove this job on the Arrow nightlies?

@vibhatha
Copy link
Collaborator

vibhatha commented Jan 2, 2024

@raulcd need to check this. I doubt this could be a breaking change in the consumer testing API.

@richtia
Copy link

richtia commented Jan 2, 2024

@raulcd @vibhatha Here's a PR to fix it: substrait-io/consumer-testing#43

It was removed a while back since development was stopped on Acero, but if it's needed for tests in Arrow, it can be added back.

@raulcd
Copy link
Member Author

raulcd commented Jan 2, 2024

but if it's needed for tests in Arrow, it can be added back.

If we want to keep testing the integration on the Arrow nightly CI it is needed. If we feel is not necessary we can remove the nightly job.

@vibhatha
Copy link
Collaborator

vibhatha commented Jan 2, 2024

It would be better to discuss this and finalize.

@vibhatha
Copy link
Collaborator

vibhatha commented Jan 3, 2024

@github-actions crossbow submit test-conda-python-3.10-substrait

Copy link

github-actions bot commented Jan 3, 2024

Revision: 1d0226a

Submitted crossbow builds: ursacomputing/crossbow @ actions-a50d4cf458

Task Status
test-conda-python-3.10-substrait GitHub Actions

@vibhatha
Copy link
Collaborator

vibhatha commented Jan 3, 2024

@raulcd seems like the CIs are passing now as @richtia has merged the PR.

Copy link
Member Author

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Jan 3, 2024
@raulcd raulcd merged commit fe38d0e into apache:main Jan 3, 2024
12 of 13 checks passed
@raulcd raulcd removed the awaiting changes Awaiting changes label Jan 3, 2024
@vibhatha
Copy link
Collaborator

vibhatha commented Jan 3, 2024

@raulcd by the way I saw this failure in a few PRs recently.

@raulcd
Copy link
Member Author

raulcd commented Jan 3, 2024

Thanks @vibhatha . This is supposed to be fixed on main as this was closed yesterday #39423

Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fe38d0e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

clayburn pushed a commit to clayburn/arrow that referenced this pull request Jan 23, 2024
…apache#39426)

### Rationale for this change

Upstream substrait repo did a small refactor. We have to update our imports to match the new structure.

### What changes are included in this PR?

Update import

### Are these changes tested?
Via archery

### Are there any user-facing changes?
No
* Closes: apache#39425

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…apache#39426)

### Rationale for this change

Upstream substrait repo did a small refactor. We have to update our imports to match the new structure.

### What changes are included in this PR?

Update import

### Are these changes tested?
Via archery

### Are there any user-facing changes?
No
* Closes: apache#39425

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this pull request Feb 28, 2024
…apache#39426)

### Rationale for this change

Upstream substrait repo did a small refactor. We have to update our imports to match the new structure.

### What changes are included in this PR?

Update import

### Are these changes tested?
Via archery

### Are there any user-facing changes?
No
* Closes: apache#39425

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Test substrait integration job has been failing for some time
3 participants