-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39425: [CI] Fix import to match new substrait repo structure #39426
Conversation
|
@github-actions crossbow submit test-conda-python-3.10-substrait |
Revision: 1d0226a Submitted crossbow builds: ursacomputing/crossbow @ actions-d7862e96be
|
@richtia @vibhatha is the
Should we remove this job on the Arrow nightlies? |
@raulcd need to check this. I doubt this could be a breaking change in the consumer testing API. |
@raulcd @vibhatha Here's a PR to fix it: substrait-io/consumer-testing#43 It was removed a while back since development was stopped on Acero, but if it's needed for tests in Arrow, it can be added back. |
If we want to keep testing the integration on the Arrow nightly CI it is needed. If we feel is not necessary we can remove the nightly job. |
It would be better to discuss this and finalize. |
@github-actions crossbow submit test-conda-python-3.10-substrait |
Revision: 1d0226a Submitted crossbow builds: ursacomputing/crossbow @ actions-a50d4cf458
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fe38d0e. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…apache#39426) ### Rationale for this change Upstream substrait repo did a small refactor. We have to update our imports to match the new structure. ### What changes are included in this PR? Update import ### Are these changes tested? Via archery ### Are there any user-facing changes? No * Closes: apache#39425 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
…apache#39426) ### Rationale for this change Upstream substrait repo did a small refactor. We have to update our imports to match the new structure. ### What changes are included in this PR? Update import ### Are these changes tested? Via archery ### Are there any user-facing changes? No * Closes: apache#39425 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
…apache#39426) ### Rationale for this change Upstream substrait repo did a small refactor. We have to update our imports to match the new structure. ### What changes are included in this PR? Update import ### Are these changes tested? Via archery ### Are there any user-facing changes? No * Closes: apache#39425 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Rationale for this change
Upstream substrait repo did a small refactor. We have to update our imports to match the new structure.
What changes are included in this PR?
Update import
Are these changes tested?
Via archery
Are there any user-facing changes?
No