Skip to content

fix: add aceroconsumer back to conftest#43

Merged
richtia merged 1 commit intosubstrait-io:mainfrom
richtia:add_back_aceroconsumer
Jan 2, 2024
Merged

fix: add aceroconsumer back to conftest#43
richtia merged 1 commit intosubstrait-io:mainfrom
richtia:add_back_aceroconsumer

Conversation

@richtia
Copy link
Copy Markdown
Member

@richtia richtia commented Jan 2, 2024

Adding back the AceroConsumer to conftest so it can be tested with

Copy link
Copy Markdown
Contributor

@vibhatha vibhatha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richtia any specific reason why this was removed before?

@richtia
Copy link
Copy Markdown
Member Author

richtia commented Jan 2, 2024

@richtia any specific reason why this was removed before?

Nothing other than Acero development stopping.

@richtia richtia merged commit c15fd4b into substrait-io:main Jan 2, 2024
@vibhatha
Copy link
Copy Markdown
Contributor

vibhatha commented Jan 2, 2024

@richtia should we worry about these failed checks?

@vibhatha
Copy link
Copy Markdown
Contributor

vibhatha commented Jan 2, 2024

And @richtia Thanks for working on this very swiftly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants