Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-4932: [GLib] Use G_DECLARE_DERIVABLE_TYPE macro #3945

Closed
wants to merge 2 commits into from
Closed

ARROW-4932: [GLib] Use G_DECLARE_DERIVABLE_TYPE macro #3945

wants to merge 2 commits into from

Conversation

mrkn
Copy link
Member

@mrkn mrkn commented Mar 17, 2019

No description provided.

@mrkn mrkn mentioned this pull request Mar 17, 2019
Closed
@codecov-io
Copy link

codecov-io commented Mar 17, 2019 •
edited
Loading

Codecov Report

Merging #3945 into master will increase coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3945      +/-   ##
==========================================
+ Coverage   87.75%   88.57%   +0.81%     
==========================================
  Files         727      593     -134     
  Lines       89507    79924    -9583     
  Branches     1252        0    -1252     
==========================================
- Hits        78547    70790    -7757     
+ Misses      10842     9134    -1708     
+ Partials      118        0     -118
Impacted Files Coverage Δ
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
js/src/visitor/vectorloader.ts
js/src/visitor.ts
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d2280f...4067d10. Read the comment docs.

kou
kou requested changes Mar 17, 2019
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could you check my comment?

c_glib/arrow-glib/array-builder.h Outdated
garrow_string_array_builder,
GARROW,
STRING_ARRAY_BUILDER,
GArrowArrayBuilder)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use GArrowBinaryArrayBuilder as the parent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this. I've fixed it.

kou
kou approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou closed this in 2f740ac Mar 18, 2019
@mrkn mrkn deleted the glib_use_g_declare_derivable_type branch April 25, 2019 06:13
@asfimport asfimport mentioned this pull request Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrkn @codecov-io @kou