ARROW-4939: [Python] Add wrapper for "sum" kernel #3954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
reviewed
Mar 18, 2019
python/pyarrow/tests/test_compute.py
Outdated
| import pyarrow as pa | ||
|
|
||
| def test_sum(): | ||
| types = [pa.int8(), pa.int16(), pa.int64(), |
There was a problem hiding this comment.
You could use pytest.mark.parametrize to run the test for each type instead of the for-loop. That will make test reports more readable.
There was a problem hiding this comment.
Thanks, I fixed it!
|
Are there more comments (especially concerning the Scalar wrappers, which we didn't have before)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.