-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-39552: [Go] inclusion of option to use replacer when creating csv strings with go library #39576
Conversation
…g csv strings with go library
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems good to me. Thanks much!
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit c170af4. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…g csv strings with go library (apache#39576) Rationale for this change Make it possible to remove unwanted characters from strings What changes are included in this PR? Add new function to optionally setup a replacer in csv Writer Write method Are these changes tested? Yes Are there any user-facing changes? Adds an optional methods. * Closes: apache#39552 Lead-authored-by: Jânio <janioprates@gmail.com> Co-authored-by: janiodev <janio.otoni@blip.ai> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
…g csv strings with go library (apache#39576) Rationale for this change Make it possible to remove unwanted characters from strings What changes are included in this PR? Add new function to optionally setup a replacer in csv Writer Write method Are these changes tested? Yes Are there any user-facing changes? Adds an optional methods. * Closes: apache#39552 Lead-authored-by: Jânio <janioprates@gmail.com> Co-authored-by: janiodev <janio.otoni@blip.ai> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
…g csv strings with go library (apache#39576) Rationale for this change Make it possible to remove unwanted characters from strings What changes are included in this PR? Add new function to optionally setup a replacer in csv Writer Write method Are these changes tested? Yes Are there any user-facing changes? Adds an optional methods. * Closes: apache#39552 Lead-authored-by: Jânio <janioprates@gmail.com> Co-authored-by: janiodev <janio.otoni@blip.ai> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
…g csv strings with go library (apache#39576) Rationale for this change Make it possible to remove unwanted characters from strings What changes are included in this PR? Add new function to optionally setup a replacer in csv Writer Write method Are these changes tested? Yes Are there any user-facing changes? Adds an optional methods. * Closes: apache#39552 Lead-authored-by: Jânio <janioprates@gmail.com> Co-authored-by: janiodev <janio.otoni@blip.ai> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
…g csv strings with go library (apache#39576) Rationale for this change Make it possible to remove unwanted characters from strings What changes are included in this PR? Add new function to optionally setup a replacer in csv Writer Write method Are these changes tested? Yes Are there any user-facing changes? Adds an optional methods. * Closes: apache#39552 Lead-authored-by: Jânio <janioprates@gmail.com> Co-authored-by: janiodev <janio.otoni@blip.ai> Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Rationale for this change
Make it possible to remove unwanted characters from strings
What changes are included in this PR?
Add new function to optionally setup a replacer in csv Writer Write method
Are these changes tested?
Yes
Are there any user-facing changes?
Adds an optional methods.