Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4980: [GLib] Use GInputStream as the parent of GArrowInputStream #3997

Closed
wants to merge 1 commit into from

Conversation

kou
Copy link
Member

@kou kou commented Mar 21, 2019

If we use GInputStream as the parent of GArrowInputStream, we can use
GInputStream related feature such as encoding conversion to Arrow's
input stream.

If we use GInputStream as the parent of GArrowInputStream, we can use
GInputStream related feature such as encoding conversion to Arrow's
input stream.
Copy link
Contributor

@shiro615 shiro615 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiro615 shiro615 closed this in 72ce489 Mar 22, 2019
@kou kou deleted the glib-gio-input-stream branch March 23, 2019 20:20
kszucs pushed a commit that referenced this pull request Mar 24, 2019
If we use GInputStream as the parent of GArrowInputStream, we can use
GInputStream related feature such as encoding conversion to Arrow's
input stream.

Author: Kouhei Sutou <kou@clear-code.com>

Closes #3997 from kou/glib-gio-input-stream and squashes the following commits:

5738193 <Kouhei Sutou>  Use GInputStream as the parent of GArrowInputStream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants