Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-38372: [C++] replace memo table with a swiss table like implementation #40915

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

GH-38372: [C++] replace memo table with a swiss table like implementation #40915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2198a47
GH-38372: [C++] replace memoTable with a swiss table like implementation
SGZW Mar 31, 2024
45e4482
Merge branch 'apache:main' into add_swiss_table
SGZW Apr 6, 2024
88dd833
Merge branch 'apache:main' into add_swiss_table
SGZW Apr 12, 2024
a448ac2
Merge branch 'apache:main' into add_swiss_table
SGZW Apr 14, 2024
6b8f8a9
Merge branch 'apache:main' into add_swiss_table
SGZW May 26, 2024
6b7cc4b
add fastmod path
SGZW May 26, 2024
779d6bd
add quadratic_probing
SGZW Jun 19, 2024
7b3d29b
Merge branch 'apache:main' into add_swiss_table
SGZW Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions cpp/src/arrow/compute/kernels/scalar_set_lookup.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,15 +49,13 @@ struct SetLookupState : public SetLookupStateBase {
const ArrayData& value_set = *options.value_set.array();
memo_index_to_value_index.reserve(value_set.length);
lookup_table =
MemoTable(memory_pool,
::arrow::internal::HashTable<char>::kLoadFactor * value_set.length);
MemoTable(memory_pool, value_set.length);
RETURN_NOT_OK(AddArrayValueSet(options, *options.value_set.array()));
} else if (options.value_set.kind() == Datum::CHUNKED_ARRAY) {
const ChunkedArray& value_set = *options.value_set.chunked_array();
memo_index_to_value_index.reserve(value_set.length());
lookup_table =
MemoTable(memory_pool,
::arrow::internal::HashTable<char>::kLoadFactor * value_set.length());
MemoTable(memory_pool, value_set.length());

int64_t offset = 0;
for (const std::shared_ptr<Array>& chunk : value_set.chunks()) {
Expand Down
Loading
Loading