Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-4467: [Rust] [DataFusion] Create a REPL & Dockerfile for DataFusion #4147

Closed
wants to merge 3 commits into from

Conversation

zhzy0077
Copy link
Contributor

This pr contains a REPL implementation of DataFusion and create a Dockerfile for it.

Which achieves the following workflow w/o coding:
https://gist.github.com/zhzy0077/4fd32795691ae7725a323d9a61e55c9d

Known Issue:

  1. Don't support unsigned data types since sqlparser-rs haven't supported yet.
  2. I don't know how to push docker images to apache/arrow-datafusion. Help wanted here @andygrove

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic 👍

Pushing to a docker repo would need to be part of the release process and requires a discussion on the mailing list.

#### Use as a bin
##### Build your own bin(requires rust toolchains)
```sh
git clone https://github/apache/arrow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove the git clone step since this README is already in the cloned repo?

Copy link
Contributor Author

@zhzy0077 zhzy0077 Apr 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a user will view README on Gtihub prior to clone this repo?
(At least I would prefer to read the README before cloning something.)

# specific language governing permissions and limitations
# under the License.

FROM rustlang/rust:nightly
Copy link
Member

@kszucs kszucs Apr 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created issue to make it available from docker-compose https://issues.apache.org/jira/browse/ARROW-5170

@kszucs kszucs closed this in cc5d687 Apr 15, 2019
@kszucs
Copy link
Member

kszucs commented Apr 15, 2019

Thanks @zhzy0077!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants