-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41787: Update fmpp-maven-plugin output directory #41788
GH-41787: Update fmpp-maven-plugin output directory #41788
Conversation
Per convention fmpp-maven-plugin should not directly generate files under target/generated-sources but into a subdirectory. Changing config to output files under `target/generated-sources/fmpp`
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@github-actions crossbow submit -g java |
Revision: 1e23820 Submitted crossbow builds: ursacomputing/crossbow @ actions-40ad1e96f7 |
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 420c01a. There weren't enough matching historic benchmark results to make a call on whether there were regressions. The full Conbench report has more details. |
### Rationale for this change Per convention fmpp-maven-plugin should not directly generate files under target/generated-sources but into a subdirectory. ### What changes are included in this PR? Changing config to output files under `target/generated-sources/fmpp` ### Are these changes tested? CI ### Are there any user-facing changes? No * GitHub Issue: apache#41787 Authored-by: Laurent Goujon <laurent@apache.org> Signed-off-by: David Li <li.davidm96@gmail.com>
Rationale for this change
Per convention fmpp-maven-plugin should not directly generate files under target/generated-sources but into a subdirectory.
What changes are included in this PR?
Changing config to output files under
target/generated-sources/fmpp
Are these changes tested?
CI
Are there any user-facing changes?
No