ARROW-5165: [Python] update dev installation docs for --build-type + validate in setup.py #4192
Conversation
…validate in setup.py
jorisvandenbossche
changed the title
python/setup.py
Outdated
| @@ -171,6 +171,11 @@ def initialize_options(self): | |||
| 'gandiva'] | |||
|
|
|||
| def _run_cmake(self): | |||
| # check if build_type is correctly passed / set | |||
| if self.build_type not in ('release', 'debug'): | |||
There was a problem hiding this comment.
I would lowercase this as sometimes it is passed as "RELEASE" or "RelWithDebInfo". Also note there are more value than this, see https://cmake.org/cmake/help/v3.0/variable/CMAKE_BUILD_TYPE.html
There was a problem hiding this comment.
OK on the lower case.
I can also remove the check in its entirety, if it would be too strict (don't know if those other build types are used within arrow development). I mainly wanted to address the issue described in https://issues.apache.org/jira/browse/ARROW-5165 that the error you now get is rather confusing.
|
@jorisvandenbossche If you want to make a deeper dive in the development docs and fix/refresh them, you're welcome :-) |
They are actually already quite nice, but will certainly report issues / make fixes while going through them. |
--build-type=$ARROW_BUILD_TYPEin the docs, sinceARROW_BUILD_TYPEis not set, and 'release' is already the default.self.build_typeso that doing--build-type=$ARROW_BUILD_TYPEwithout having the env variable set gives a helpful error message instead of failing when bundling includes