GH-40062: [C++] Move RecordBatch::ToTensor code from record_batch.cc to tensor.cc #41932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have run the benchmarks locally just in case, everything is looking OK. |
github-actions
bot
added
awaiting merge
|
@felipecrv mind having a quick look? This PR only moves the existing code from record_batch.cc to tensor.cc and changes the signature of the main method from |
|
I will merge this so I can make #41870 easier to review. We can move code reviews to the linked PR. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
Jun 5, 2024
…ch.cc to tensor.cc (apache#41932) ### Rationale for this change This is a precursor PR to apache#41870 with the purpose to make the review of apache#41870 easier (the diff of the code will be visible as it currently isn't because the code was moved to table.cc. I should also live in tensor.cc). ### What changes are included in this PR? The code from `RecordBatch::ToTensor` in record_batch.cc is moved to `RecordBatchToTensor` in tensor.cc. ### Are these changes tested? Existing tests should pass. ### Are there any user-facing changes? No. **This PR does not close the linked issue yet, it is just a precursor!** * GitHub Issue: apache#40062 Authored-by: AlenkaF <frim.alenka@gmail.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 5a86441. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
Sorry for not looking at this before @AlenkaF. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is a precursor PR to #41870 with the purpose to make the review of #41870 easier (the diff of the code will be visible as it currently isn't because the code was moved to table.cc. I should also live in tensor.cc).
What changes are included in this PR?
The code from
RecordBatch::ToTensorin record_batch.cc is moved toRecordBatchToTensorin tensor.cc.Are these changes tested?
Existing tests should pass.
Are there any user-facing changes?
No.
This PR does not close the linked issue yet, it is just a precursor!