[WIP] ARROW-3294: [C++][Flight] Support Flight on Windows #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Signals are entirely different on Windows, so this will need thinking a bit. |
|
My advice would be to simply disable the signal handling code on Windows. It's only required to be able to stop the daemon using Ctrl-C on Unix, but perhaps no such code is required on Windows. |
|
OK. I can add some defines around that code to see how much further I can get |
|
Rebased and fixed conflicts. |
|
@wesm I'm taking this up for now. |
pitrou
changed the title
pitrou
force-pushed
the
ARROW-3294-try-2
branch
3 times, most recently
from
c565842
to
b5ea2a1
Compare
|
I'm gonna open another PR with a branch on my fork, so as to use my AppVeyor account. |
|
Superseded by #4410. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pitrou @lihalite I'll need a little bit of help with this because
sigactionis not available on Windows so the signal handling code will need some love (I found discussion of this issue here: https://stackoverflow.com/questions/32389905/sigaction-and-porting-linux-code-to-windows).https://gist.github.com/wesm/1565ca0248d77d8ffc2411ce39119ed0
Once that's addressed I can push on to trying to get the unit tests working