Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-3294: [C++][Flight] Support Flight on Windows #4410

Closed
wants to merge 1 commit into from
Closed

ARROW-3294: [C++][Flight] Support Flight on Windows #4410

wants to merge 1 commit into from

Conversation

pitrou
Copy link
Member

@pitrou pitrou commented May 29, 2019

No description provided.

@pitrou pitrou mentioned this pull request May 29, 2019
Closed
@pitrou pitrou force-pushed the ARROW-3294-flight-windows branch from dc6b821 to 7da51ae Compare May 29, 2019 14:48
wesm
wesm reviewed May 29, 2019
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. I'll review again when the PR is finished

@pitrou pitrou force-pushed the ARROW-3294-flight-windows branch 12 times, most recently from 1328785 to f44f5f9 Compare May 29, 2019 18:00
@pitrou pitrou changed the title [WIP] ARROW-3294: [C++][Flight] Support Flight on Windows ARROW-3294: [C++][Flight] Support Flight on Windows May 29, 2019
@pitrou
Copy link
Member Author

pitrou commented May 29, 2019

Should be ok now. Of course, a last-minute failure on CI is not out of question.

@pitrou pitrou force-pushed the ARROW-3294-flight-windows branch from f44f5f9 to f394709 Compare May 29, 2019 19:34
@pitrou
Copy link
Member Author

pitrou commented May 30, 2019

@lidavidm Any concerns here?

@pitrou pitrou force-pushed the ARROW-3294-flight-windows branch from f394709 to 1db74d7 Compare May 30, 2019 18:23
@pitrou pitrou force-pushed the ARROW-3294-flight-windows branch from 1db74d7 to bd4979b Compare May 31, 2019 07:45
@wesm
Copy link
Member

wesm commented May 31, 2019

Nice green build. I'm having a final look through

wesm
wesm approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. thanks for doing this!

ci/appveyor-cpp-setup.bat
rd /s /q C:\OpenSSL-v11-Win32
rd /s /q C:\OpenSSL-v11-Win64
rd /s /q C:\OpenSSL-v111-Win32
rd /s /q C:\OpenSSL-v111-Win64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuck

@wesm wesm closed this in dbeab70 May 31, 2019
@pitrou pitrou deleted the ARROW-3294-flight-windows branch June 1, 2019 11:38
@asfimport asfimport mentioned this pull request Jun 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

@wesm wesm wesm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pitrou @wesm @lidavidm