GH-42015: [MATLAB] Executing tfeather.m test class causes MATLAB to crash on windows-2022 after MSVC update from 14.39.33519 to 14.40.33807
#42123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the |
|
+1 |
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 512d245. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 23 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
After the
windows-2022GitHub runner image was updated last week, MATLAB began crashing when running the unit tests inarrow/matlab/test/tfeather.mon Windows. As part of the update, VS 2022 was updated from17.9.34902.65to17.10.34928.147and MSVC was updated from14.39.33519to14.40.33807.It looks like many other projects have run into this issue as well:
The suggested workaround for this crash is to supply the flag
_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTORwhen building.What changes are included in this PR?
_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTORflag when building Arrow C++.Are these changes tested?
N/A. Existing tests used.
Are there any user-facing changes?
No.
tfeather.mtest class causes MATLAB to crash onwindows-2022after MSVC update from 14.39.33519 to 14.40.33807 #42015