Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Go] Remove extraneous godocs line #42248

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

wkalt
Copy link
Contributor

@wkalt wkalt commented Jun 22, 2024

Rationale for this change

Encountered this line browsing docs at https://pkg.go.dev/github.com/apache/arrow/go/v16/arrow.

@zeroshade zeroshade merged commit 38bb310 into apache:main Jun 24, 2024
19 of 21 checks passed
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Jun 24, 2024
@kou
Copy link
Member

kou commented Jun 24, 2024

@zeroshade Could you use our merge script even when we merge a MINOR PR? It removes comments from a PR description and use the prepared description as commit message.

For example, the <!-- Thanks ... --> part in 38bb310 is removed by our merge script.

Copy link

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 38bb310.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 27 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants