Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-2707: [C++] Add Table::Slice #4270

Closed
wants to merge 1 commit into from
Closed

ARROW-2707: [C++] Add Table::Slice #4270

wants to merge 1 commit into from

Conversation

bkietz
Copy link
Member

@bkietz bkietz commented May 8, 2019

Allow zero copy slices on Tables

@bkietz
Copy link
Member Author

bkietz commented May 8, 2019 •
edited
Loading

Probably spurious: https://travis-ci.org/apache/arrow/jobs/529571148#L1183

Looks like: #4276

xhochy
xhochy approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

Rebase for green build

@bkietz bkietz force-pushed the 2707-Implement-TableSlice-methods-using-Colum branch from e5dcc9e to 1ac0310 Compare May 8, 2019 17:19
@bkietz
Copy link
Member Author

bkietz commented May 8, 2019

@xhochy rebased but still red

@nealrichardson
Copy link
Member

Failures are from pypa/setuptools-scm#333 still, it appears.

fsaintjacques
fsaintjacques approved these changes May 9, 2019
View reviewed changes
Copy link
Contributor

@fsaintjacques fsaintjacques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@bkietz bkietz force-pushed the 2707-Implement-TableSlice-methods-using-Colum branch from 1ac0310 to 54b6045 Compare May 9, 2019 17:34
@wesm wesm closed this in 3eb07b7 May 10, 2019
@wesm
Copy link
Member

wesm commented May 10, 2019

thanks @bkietz!

@bkietz bkietz deleted the 2707-Implement-TableSlice-methods-using-Colum branch February 25, 2021 16:10
@asfimport asfimport mentioned this pull request May 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy approved these changes

@fsaintjacques fsaintjacques fsaintjacques approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bkietz @nealrichardson @wesm @xhochy @fsaintjacques