Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-5498: [C++][CI] Fix Flatbuffers related error with MinGW #4465

Closed
wants to merge 1 commit into from

Conversation

kou
Copy link
Member

@kou kou commented Jun 3, 2019

We should send a pull request that adds -DCMAKE_BUILD_TYPE=Release to
https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-flatbuffers/PKGBUILD
.

@codecov-io
Copy link

Codecov Report

Merging #4465 into master will increase coverage by 0.92%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4465      +/-   ##
==========================================
+ Coverage   88.26%   89.19%   +0.92%     
==========================================
  Files         846      696     -150     
  Lines      103357    91516   -11841     
  Branches     1253        0    -1253     
==========================================
- Hits        91229    81627    -9602     
+ Misses      11881     9889    -1992     
+ Partials      247        0     -247
Impacted Files Coverage Δ
go/arrow/ipc/writer.go
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
go/arrow/ipc/file_reader.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
... and 141 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f5979...76f49a6. Read the comment docs.

Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wesm wesm closed this in 12ed730 Jun 4, 2019
@kou kou deleted the cpp-appveyor-flatbuffers branch June 4, 2019 01:50
@kou
Copy link
Member Author

kou commented Jun 4, 2019

Done: msys2/MINGW-packages#5471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants