ARROW-5823: [Rust] CI scripts miss --all-targets cargo argument #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sunchao @andygrove @nevi-me Please help to review. |
sunchao
approved these changes
Jul 2, 2019
There was a problem hiding this comment.
NIce catch @liurenjie1024 ! Always forgot about benchmark code ...
kszucs
changed the title
kszucs
changed the title
kou
pushed a commit
that referenced
this pull request
Jul 4, 2019
Rust build breaks because some changes in array builder. However this error is not detected in ci scripts because missing --all-targets in cargo build command. Author: Renjie Liu <liurenjie2008@gmail.com> Closes #4778 from liurenjie1024/fix-build and squashes the following commits: c00f8bc <Renjie Liu> Fix build break
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
Rust build breaks because some changes in array builder. However this error is not detected in ci scripts because missing --all-targets in cargo build command. Author: Renjie Liu <liurenjie2008@gmail.com> Closes #4778 from liurenjie1024/fix-build and squashes the following commits: c00f8bc <Renjie Liu> Fix build break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust build breaks because some changes in array builder. However this error is not detected in ci scripts because missing --all-targets in cargo build command.