ARROW-5594: [C++] add UnionArrays support to Take/Filter kernels #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emkornfield
changed the title
kszucs
force-pushed
the
master
branch
2 times, most recently
from
ed180da
to
85fe336
Compare
Codecov Report
@@ Coverage Diff @@
## master #4866 +/- ##
==========================================
+ Coverage 87.46% 89.1% +1.64%
==========================================
Files 994 717 -277
Lines 140389 100548 -39841
Branches 1418 0 -1418
==========================================
- Hits 122788 89591 -33197
+ Misses 17239 10957 -6282
+ Partials 362 0 -362
Continue to review full report at Codecov.
|
pprudhvi
pushed a commit
to pprudhvi/arrow
that referenced
this pull request
Aug 11, 2019
Take and Filter kernels should now be able to operate on arrays of any type. Closes apache#4866 from bkietz/5594-add-support-for-UnionArrays-to-Take-and- and squashes the following commits: 2e2e589 <Benjamin Kietzman> correct union density test 1c0b29f <Benjamin Kietzman> address review comments 1e07cfb <Benjamin Kietzman> add tests for dense union array density 3df7bf3 <Benjamin Kietzman> add Take/Filter(UnionArrays) Authored-by: Benjamin Kietzman <bengilgit@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take and Filter kernels should now be able to operate on arrays of any type.