Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-6247: [Java] Provide a common interface for float4 and float8 vectors #5132

Closed
wants to merge 1 commit into from
Closed

ARROW-6247: [Java] Provide a common interface for float4 and float8 vectors #5132

wants to merge 1 commit into from

Conversation

liyafan82
Copy link
Contributor

We want to provide an interface for floating point vectors (float4 & float8). This interface will make it convenient for many operations on a vector. With this interface, the client code will be greatly simplified, with many branches/switch removed.

The design is similar to BaseIntVector (the interface for all integer vectors). We provide 3 methods for setting & getting floating point values:

     setWithPossibleTruncate

     setSafeWithPossibleTruncate

     getValueAsDouble

@fsaintjacques fsaintjacques changed the title [ARROW-6247][Java] Provide a common interface for float4 and float8 vectors ARROW-6247: [Java] Provide a common interface for float4 and float8 vectors Aug 20, 2019
@emkornfield
Copy link
Contributor

@jacques-n thoughts on this?

@liyafan82 liyafan82 mentioned this pull request Aug 29, 2019
Closed
@emkornfield
Copy link
Contributor

+1, seems ok.

@asfimport asfimport mentioned this pull request Aug 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liyafan82 @emkornfield @fsaintjacques